Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): rework capturing and use it for all requests #5049

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

fix(tracing): rework capturing and use it for all requests #5049

wants to merge 41 commits into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.048MiB 2.049MiB -1.029KiB
Postgres (gzip) 821.508KiB 821.937KiB -439.000B
Mysql 2.013MiB 2.013MiB 466.000B
Mysql (gzip) 808.798KiB 807.916KiB 904.000B
Sqlite 1.911MiB 1.910MiB 524.000B
Sqlite (gzip) 767.829KiB 768.137KiB -316.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5049 will not alter performance

Comparing rework-tracing (1006ad1) with main (5dbef10)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln force-pushed the rework-tracing branch 3 times, most recently from 3539cbd to e74fb4c Compare November 25, 2024 14:32
@aqrln aqrln mentioned this pull request Nov 27, 2024
Closed
@aqrln aqrln added this to the 6.1.0 milestone Nov 28, 2024
@aqrln
libs/telemetry: use tracing-futures from workspace deps
59bd82b
@aqrln
libs/telemetry: remove obsolete dependency
2c0a330
@aqrln
Update tracing and tracing-subscriber
01a3a95
@aqrln
Add capturing::ng module
3b9c0d3
@aqrln
We don't use tide anymore
58e61c3
@aqrln
Add TraceParent and WithContext
f6f16c1
@aqrln
Add SpanBuilder
49408c4
@aqrln
Implement SpanBuilder and SpanAttributeVisitor
2939f5f
@aqrln
Add Collector trait
edaf457
@aqrln
Add tests for layer
f634df1
@aqrln
Fix import
bc63474
@aqrln
Sort attributes map
402a0e7
@aqrln
Style change
aa95a1d
@aqrln
Fix redacting span IDs in Options
0bdd3b0
@aqrln
Remove unnecessary qualifier
e5be3e9
@aqrln
Update snapshot to what's expected
b833626
@aqrln
Declare empty field in test
a62f199
@aqrln
Add test for renamed span
2130f5f
@aqrln
Add test_follows_from
5663849
@aqrln
Remove sleep
53957e1
@aqrln
Add on_event
48990f2
@aqrln
Implement events capturing in subscriber layer
4c45ac9
@aqrln
Add span IDs to events
43ab299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@aqrln