Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql-schema-describer): support "DISTINCT ON" on CockroachDB #5046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@jkomyno jkomyno requested a review from a team as a code owner November 15, 2024 15:45
@jkomyno jkomyno requested review from aqrln and removed request for a team November 15, 2024 15:45
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #5046 will not alter performance

Comparing feat/distinct-on-cockroachdb (320e2d6) with main (378004b)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.032MiB 2.032MiB 0.000B
Postgres (gzip) 816.877KiB 816.877KiB 0.000B
Mysql 1.995MiB 1.995MiB 0.000B
Mysql (gzip) 802.624KiB 802.624KiB 0.000B
Sqlite 1.895MiB 1.895MiB 0.000B
Sqlite (gzip) 763.270KiB 763.271KiB -1.000B

@jkomyno
Copy link
Contributor Author

jkomyno commented Nov 15, 2024

DISTINCT ON + GROUP BY fails on JSONB columns due to cockroachdb/cockroach#35706, which was fixed for CockroachDB v23.2+. However, we're currently only testing CockroachDB until v23.1. We can't act on this task until we solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant