-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quaint): enable integrated-auth-gssapi tiberius feature #4980
base: main
Are you sure you want to change the base?
feat(quaint): enable integrated-auth-gssapi tiberius feature #4980
Conversation
793b297
to
c0ea0cd
Compare
Won't this make Prisma depend on additional shared libraries to be installed on the system? If so, it's a breaking change. |
c625829
to
980270d
Compare
Yes, according to https://github.com/prisma/tiberius#integrated-authentication-trustedconnection-on-nix, on *nix:
I am hoping that is only required if the the user actually uses the integrated auth feature on a *nix machine, otherwise this whole thing is probably a no-go. If that is true, then I don't think it should be considered a breaking change. Unfortunately this is my first foray into Rust and Prisma so I don't know how all the pieces fit together during runtime yet. |
This should extend support for MSSQL integrated authentication to *nix systems. Prisma currently only supports this feature on Windows.
928afbf
to
8f85bed
Compare
@aqrln It looks like @pimeys was spending some time looking into the implications of enabling this gssapi feature on Prisma a while ago (estokes/libgssapi#1 (comment)). I would be curious to know where he or the Prisma org ended up on this. |
This PR should extend support for MSSQL integrated authentication to *nix systems. Prisma currently only supports this feature on Windows.
The Tiberius SQL Server driver used by Prisma can support integrated authentication on *nix by enabling its
integrated-auth-gssapi
feature (see https://github.com/prisma/tiberius#integrated-authentication-trustedconnection-on-nix).Closes #4974.