-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce FormControl Hint and Validation font-size #831
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1697846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
30f41a3
to
89831d8
Compare
d0efea1
to
83450a7
Compare
@danielguillan Just a heads up that I've updated this to use the Visually it should be the same, although I've also corrected the font-weight as that was pointing to a non-existent variable before |
6ba4bd2
to
1697846
Compare
Summary
Brings the font-size of
FormControl.Hint
andFormControl.Validation
down to 100 (14px) to align with Figma and replaces their custom implementation with theText
component.Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots
See visual regression tests