Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce FormControl Hint and Validation font-size #831

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Nov 26, 2024

Summary

Brings the font-size of FormControl.Hint and FormControl.Validation down to 100 (14px) to align with Figma and replaces their custom implementation with the Text component.

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots

See visual regression tests

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 1697846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Minor
@primer/brand-primitives Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 26, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 26, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshfarrant joshfarrant force-pushed the joshfarrant/formcontrol-validation-text-size branch from 30f41a3 to 89831d8 Compare November 29, 2024 09:38
@joshfarrant joshfarrant force-pushed the joshfarrant/formcontrol-validation-text-size branch 2 times, most recently from d0efea1 to 83450a7 Compare November 29, 2024 09:52
@joshfarrant
Copy link
Contributor Author

@danielguillan Just a heads up that I've updated this to use the Text component instead (preempting feedback based on this feedback on a separate PR).

Visually it should be the same, although I've also corrected the font-weight as that was pointing to a non-existent variable before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants