Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] stringify cutscenes.s #159

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

rpadaki
Copy link
Contributor

@rpadaki rpadaki commented Sep 24, 2023

For this PR, I added a bunch of heuristics to the script I used for #157. This lets me find most of the strings in this file, though it's very possible that I'm missing some.

  • If I see an unknown byte, I log it and assume the whole block is not a string
  • If a block is less than 5 bytes, I assume it's not a string (or small enough that we can do those by hand when they come up)
  • If a block ends with 5 or more null bytes, I assume it's not a string (Something something alignment? This is totally a heuristic)

The more complete charmap.txt is, the more strings I can find. The script is a little too finicky to be shared rn but I'll clean it up when I have time.

Copy link
Collaborator

@AnonymousRandomPerson AnonymousRandomPerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let #158 merge before this, per Discord convo.

@SethBarberee
Copy link
Collaborator

Needs rebase

charmap.txt Outdated Show resolved Hide resolved
charmap.txt Outdated Show resolved Hide resolved
@SethBarberee SethBarberee merged commit 5f3590e into pret:master Sep 26, 2023
1 check passed
@rpadaki rpadaki deleted the roshan/stringify-cutscenes branch September 26, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants