You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem description
Fix SerializerConfigBuilder class createGroup method setting invalid FullTransitive compatibility for non-Avro formats by default.
(packet io.pravega.schemaregistry.serializer.shared.impl )
F.e this group creation will fail with "BadArgumentException: Group properties invalid" for non-Avro formats
Because by default createGroup method sets invalid FullTransitive compatibility.
Problem location
In this case from "BadArgumentException: Group properties invalid" Exception it is not obvious that problem is with compatibility.
In logs there will be only following
[RestServer RUNNING] WARN i.p.s.s.r.r.AbstractResource - Bad argument for request createGroup failed with exception: . null. {}
May be we should add some log.error message before return to isValidCompatibilityForFormat method for Protobuf/Custom/Json/Any cases:
caseAvro:
returntrue;
caseProtobuf:
// Only Allow Any or Deny All are allowed values. caseJson:
// Only Allow Any or Deny All are allowed values. caseCustom:
// Only Allow Any or Deny All are allowed values. caseAny:
booleanisCompatibilityValid = compatibility.getType().equals(Compatibility.Type.AllowAny) || compatibility.getType().equals(Compatibility.Type.DenyAll);
if (! isCompatibilityValid) {
log.error("Invalid compatibility type for serializationFormat {}, only Allow Any or Deny All is possible for this format");
}
returnisCompatibilityValid;
...
Suggestions for an improvement
The text was updated successfully, but these errors were encountered:
jingerbread
changed the title
Fix create default group failed with "BadArgumentException: Group properties invalid" Excepiton for non-Avro formats,
Fix "BadArgumentException: Group properties invalid" for non-Avro formats when creating group without specifying Compatibility type
Oct 6, 2020
jingerbread
changed the title
Fix "BadArgumentException: Group properties invalid" for non-Avro formats when creating group without specifying Compatibility type
Fix SerializerConfigBuilder class createGroup method setting invalid FullTransitive compatibility for non-Avro formats by default.
Oct 6, 2020
Problem description
Fix SerializerConfigBuilder class
createGroup
method setting invalidFullTransitive
compatibility for non-Avro formats by default.(packet io.pravega.schemaregistry.serializer.shared.impl )
F.e this group creation will fail with "BadArgumentException: Group properties invalid" for non-Avro formats
Because by default
createGroup
method sets invalidFullTransitive
compatibility.Problem location
In this case from "BadArgumentException: Group properties invalid" Exception it is not obvious that problem is with compatibility.
In logs there will be only following
May be we should add some log.error message before return to
isValidCompatibilityForFormat
method for Protobuf/Custom/Json/Any cases:Suggestions for an improvement
The text was updated successfully, but these errors were encountered: