Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watermark support with the new FLIP-167 API #623

Open
crazyzhou opened this issue Dec 14, 2021 · 0 comments
Open

Watermark support with the new FLIP-167 API #623

crazyzhou opened this issue Dec 14, 2021 · 0 comments

Comments

@crazyzhou
Copy link
Contributor

Problem description
In FLIP-167, a new watermark API is introduced in both the new and old Sink API
We can

  • Change our current watermark implementation in SinkFunction implementation. We can get rid of the periodic checking per event and only propagate the watermark to Pravega in the writeWatermark call.
  • For new Sink API, add the watermark propagation logic in the SinkWriter and let user use an enableWatermarkPropagation(true) call to trigger in the builder.

Problem location
the new and old Sink API

Suggestions for an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant