Only need to wait for a single scheduler thread to become active #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, ponyint_sched_maybe_wakeup_if_all_asleep would wait until the number of active scheduler check variable matched the active schedule count variable. This could potentially cause it to unnecessarily wait for more than 1 scheduler thread to become fully active. This commit changes the logic to only wait until the active scheduler check variable indicates that there is at least one fully active scheduler.
ponylang-main
added
the
discuss during sync
|
not sure why the |
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, ponyint_sched_maybe_wakeup_if_all_asleep would wait until the number of active scheduler check variable matched the active schedule count variable. This could potentially cause it to unnecessarily wait for more than 1 scheduler thread to become fully active.
This commit changes the logic to only wait until the active scheduler check variable indicates that there is at least one fully active scheduler.