-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildings rendering differently on Chef instance #5
Comments
@baldur could you help here, please? |
@robhawkes looks like it is just pointed to head
In the node_modules directory it's head is
|
I've pushed a new version number to the |
It looks like CircleCI is using the updated |
@robhawkes great ... closing for now then |
I've re-opened for now as the buildings are still different on the dev server for some reason – both larger and lit differently. I haven't pinned it down yet but the new I'm wondering if it's the fact we're using a slightly different assimp. Do you know which version has been installed on the dev server? This is the response to
If it's the same version then I'm out of ideas for the moment, so I'm hoping there's a difference here. It's probably worth my time to work out how to build a linux binary from the same source as the OSX one. |
Version 3.0--shared -st (SVNREV 1262) I can look into trying to upgrade easily ... is there a ppa that you know On Tue, Mar 31, 2015 at 11:27 AM, Robin Hawkes [email protected]
|
Well at least it looks like this might be the cause! I can't find any updated packages which is why I resorted to building my own, with what seems to be the master branch at the time Polygon City started: assimp/assimp@94f6130 Apparently there might be binaries here but the link isn't working for me: http://sourceforge.net/projects/assimp/files/assimp-3.1/ I've also just found the build FAQ so if we do need to create our own binaries than I should be able to work it out (though I don't have a copy of Linux at the moment and my Internet is appalling): https://github.com/assimp/assimp/wiki/FAQ |
ok, I'll do the same on the server On Tue, Mar 31, 2015 at 11:56 AM, Robin Hawkes [email protected]
|
@robhawkes can you post a link to a file that I can use for testing |
Try this one, it's my go-to for testing at the moment: http://cl.ly/2o2u1L351a15 It should show up at exactly the right scale when uploaded. Currently, the dev server shows it really really large (as with all the other uploads). |
@robhawkes can you try it now and see if it is doing the correct thing. I installed things manually so I want to verify that this was the issue before I package up the work |
Yeah, that worked! Seems to be the same scale now as my local setup and also the lighting on the models is correct. What version did you end up using? |
@robhawkes just installed from head ;) |
It seems to be working great now, so happy to go with that version. Did you package it into a Linux binary, or install it some other way? If so, it'd be good to add it to the |
@robhawkes I don't know assimp well enough to know how realistic it is to bundle it with model-converter we can how ever document the process of installing it outside the chef context. I'll write it here not sure where you wanted to include it in the model-converter repo.
Then /usr/local/lib has to be added to the library path which can be done in a couple of ways
or more permanently by adding a file such as
|
@robhawkes does npm offer the ability to --compile from source? that might be an option for managing this dependency in model-converter. I'd be happy to help you figure it out. |
There's |
Buildings are rendering different on the Chef instance compared to my local copy. I think it might have something to with assimp acting differently as 20 days ago I updated it to run some checks to fix things like broken normals (perhaps this isn't being run).
Can someone confirm the HEAD commit for the model-converter dependency being used on the Chef instance? It should be 6e6ff25b176669cd527fb1349525bbf1c779fcb5. If it's not that then I've probably just not defined the dependency correctly in package.json and it's not installing the latest changes.
Local instance:
Chef instance:
The text was updated successfully, but these errors were encountered: