Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildings rendering differently on Chef instance #5

Open
robhawkes opened this issue Mar 27, 2015 · 18 comments
Open

Buildings rendering differently on Chef instance #5

robhawkes opened this issue Mar 27, 2015 · 18 comments
Labels

Comments

@robhawkes
Copy link
Contributor

Buildings are rendering different on the Chef instance compared to my local copy. I think it might have something to with assimp acting differently as 20 days ago I updated it to run some checks to fix things like broken normals (perhaps this isn't being run).

Can someone confirm the HEAD commit for the model-converter dependency being used on the Chef instance? It should be 6e6ff25b176669cd527fb1349525bbf1c779fcb5. If it's not that then I've probably just not defined the dependency correctly in package.json and it's not installing the latest changes.

Local instance:

Chef instance:

@robhawkes robhawkes added the bug label Mar 27, 2015
@bcamper
Copy link
Member

bcamper commented Mar 27, 2015

@baldur could you help here, please?

@baldur
Copy link
Contributor

baldur commented Mar 27, 2015

@robhawkes looks like it is just pointed to head

"model-converter": "git://github.com/polygon-city/model-converter"

In the node_modules directory it's head is

node_modules/model-converter$ git rev-parse HEAD
b8099838744978dd3127cc04e73be378a658510a

@robhawkes
Copy link
Contributor Author

I've pushed a new version number to the model-converter repo so hopefully that updates properly on the next CircleCI build. Interestingly, b8099838744978dd3127cc04e73be378a658510a isn't a commit in the repo that I can find.

@robhawkes
Copy link
Contributor Author

It looks like CircleCI is using the updated model-converter dependency so that's good. Once #6 is sorted out then we should always have the latest version on the dev server.

@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

@robhawkes great ... closing for now then

@baldur baldur closed this as completed Mar 31, 2015
@robhawkes
Copy link
Contributor Author

I've re-opened for now as the buildings are still different on the dev server for some reason – both larger and lit differently. I haven't pinned it down yet but the new /ping endpoint shows that we're at least using the latest repo.

I'm wondering if it's the fact we're using a slightly different assimp. Do you know which version has been installed on the dev server? This is the response to assimp version for the OSX build:

Version 3.1 -debug -noboost -shared -st (GIT commit 94f6130)

If it's the same version then I'm out of ideas for the moment, so I'm hoping there's a difference here. It's probably worth my time to work out how to build a linux binary from the same source as the OSX one.

@robhawkes robhawkes reopened this Mar 31, 2015
@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

Version 3.0--shared -st (SVNREV 1262)

I can look into trying to upgrade easily ... is there a ppa that you know
of that is more recent?

On Tue, Mar 31, 2015 at 11:27 AM, Robin Hawkes [email protected]
wrote:

I've re-opened for now as the buildings are still different on the dev
server for some reason – both larger and lit differently. I haven't pinned
it down yet but the new /ping endpoint shows that we're at least using
the latest repo.

I'm wondering if it's the fact we're using a slightly different assimp. Do
you know which version has been installed on the dev server? This is the
response to assimp version for the OSX build:

Version 3.1 -debug -noboost -shared -st (GIT commit 94f6130)

If it's the same version then I'm out of ideas for the moment, so I'm
hoping there's a difference here. It's probably worth my time to work out
how to build a linux binary from the same source as the OSX one.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@robhawkes
Copy link
Contributor Author

Well at least it looks like this might be the cause!

I can't find any updated packages which is why I resorted to building my own, with what seems to be the master branch at the time Polygon City started: assimp/assimp@94f6130

Apparently there might be binaries here but the link isn't working for me: http://sourceforge.net/projects/assimp/files/assimp-3.1/

I've also just found the build FAQ so if we do need to create our own binaries than I should be able to work it out (though I don't have a copy of Linux at the moment and my Internet is appalling): https://github.com/assimp/assimp/wiki/FAQ

@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

ok, I'll do the same on the server

On Tue, Mar 31, 2015 at 11:56 AM, Robin Hawkes [email protected]
wrote:

Well at least it looks like this might be the cause!

I can't find any updated packages which is why I resorted to building my
own, with what seems to be the master branch at the time Polygon City
started: assimp/assimp@94f6130
assimp/assimp@94f6130

Apparently there might be binaries here but the link isn't working for
me: http://sourceforge.net/projects/assimp/files/assimp-3.1/

I've also just found the build FAQ so if we do need to create our own
binaries than I should be able to work it out (though I don't have a copy
of Linux at the moment and my Internet is appalling):
https://github.com/assimp/assimp/wiki/FAQ


Reply to this email directly or view it on GitHub
#5 (comment)
.

@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

@robhawkes can you post a link to a file that I can use for testing

@robhawkes
Copy link
Contributor Author

Try this one, it's my go-to for testing at the moment: http://cl.ly/2o2u1L351a15

It should show up at exactly the right scale when uploaded. Currently, the dev server shows it really really large (as with all the other uploads).

@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

@robhawkes can you try it now and see if it is doing the correct thing. I installed things manually so I want to verify that this was the issue before I package up the work

@robhawkes
Copy link
Contributor Author

Yeah, that worked! Seems to be the same scale now as my local setup and also the lighting on the models is correct. What version did you end up using?

@baldur
Copy link
Contributor

baldur commented Mar 31, 2015

@robhawkes just installed from head ;)
Version 3.1 -debug -noboost -shared -st (GIT commit 45cc0b5)

@robhawkes
Copy link
Contributor Author

It seems to be working great now, so happy to go with that version. Did you package it into a Linux binary, or install it some other way? If so, it'd be good to add it to the model-converter repo, or send it to me and I'll add it.

@baldur
Copy link
Contributor

baldur commented Apr 1, 2015

@robhawkes I don't know assimp well enough to know how realistic it is to bundle it with model-converter we can how ever document the process of installing it outside the chef context. I'll write it here not sure where you wanted to include it in the model-converter repo.

git clone https://github.com/assimp/assimp.git
cd assimp
cmake -G 'Unix Makefiles'
sudo make install

Then /usr/local/lib has to be added to the library path which can be done in a couple of ways

export LD_LIBRARY_PATH=/usr/local/lib

or more permanently by adding a file such as

sudo echo "/usr/local/lib" > /etc/ld.so.conf.d/assimp.conf
sudo ldconfig

@baldur
Copy link
Contributor

baldur commented Apr 1, 2015

@robhawkes does npm offer the ability to --compile from source? that might be an option for managing this dependency in model-converter. I'd be happy to help you figure it out.

@robhawkes
Copy link
Contributor Author

There's node-gyp which could work for compilation, though I've not used it before so unsure how complex it makes things. I assume it allows you to set the various paths and stuff so the compiled module can actually be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants