Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LocalNet] Fix sequencer hot reloading #325

Closed
5 tasks
okdas opened this issue Jan 17, 2024 · 1 comment
Closed
5 tasks

[LocalNet] Fix sequencer hot reloading #325

okdas opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
infra Infra or tooling related improvements, additions or fixes

Comments

@okdas
Copy link
Member

okdas commented Jan 17, 2024

Objective

Hot-reloading (quick restart after the code is updated) currently doesn't work.

Origin Document

Conversation starting from this comment.

We are using helm_resource extension for Tilt which doesn't seem to work well with Hot Reloading (more info). We've had a similar set-up work in another repo, but it was using Tilt's helm() function - example. We can switch to that implementation for poktroll repo as well.

Goals

  • Sequencer process restarts automatically after code is changed.

Deliverables

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: [GitHub handle of issue owner]
Co-Owners: [OPTIONAL - GitHub handle of co-owner(s)]

@okdas okdas added the infra Infra or tooling related improvements, additions or fixes label Jan 17, 2024
@okdas okdas added this to the Shannon Quality of Life milestone Jan 17, 2024
@okdas okdas self-assigned this Jan 17, 2024
@okdas okdas added this to Shannon Jan 17, 2024
@okdas okdas moved this to 📋 Backlog in Shannon Jan 17, 2024
@okdas okdas moved this from 📋 Backlog to 🆕 New in Shannon Jan 17, 2024
@okdas okdas moved this from 🆕 New to 📋 Backlog in Shannon Jan 22, 2024
@Olshansk Olshansk moved this from 📋 Backlog to 🔖 Ready in Shannon Apr 5, 2024
@Olshansk
Copy link
Member

Olshansk commented Apr 5, 2024

Duplicated of #399.

@Olshansk Olshansk closed this as completed Apr 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Shannon Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra or tooling related improvements, additions or fixes
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants