Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water polygons are not merged #35

Open
westnordost opened this issue Mar 8, 2024 · 8 comments
Open

Water polygons are not merged #35

westnordost opened this issue Mar 8, 2024 · 8 comments
Labels
shortbread Issues with the supplied shortbread implementation

Comments

@westnordost
Copy link

The StreetComplete style draws lines around water bodies as "shore lines". The various docks and canals in Hamburg are mapped in OSM each as individual neighboring polygons.

Current behavior

Neighbouring water polygons are not merged. The area around Ellerholzbrücke looks like this:

ellerholzbruecke-tilekiln

See https://streetcomplete.app/map-osm/

Expected behavior

Neighbouring water polygons are merged. The area around Ellerholzbrücke looks like this with the JawgMaps tiles:

ellerholzbruecke-jawg

See https://streetcomplete.app/map-jawg/

@pnorman
Copy link
Owner

pnorman commented Mar 8, 2024

I should merge them for tile size, but it's valid to have them unmerged. In fact, if you're dealing with multiple water=* values, they can't be fully merged.

@westnordost
Copy link
Author

True, I think jawg just throws all water into one bucket. Shortbread doesn't.

@pnorman
Copy link
Owner

pnorman commented Mar 8, 2024

You probably want an offset polygon approach similar to the standard ways of doing strokes on roads. You should only directly style a line on a polygon if you want two of the same type of polygon to be distinct.

@westnordost
Copy link
Author

Not sure what you mean.

@pnorman
Copy link
Owner

pnorman commented Mar 8, 2024

What you're getting will always end up happening when styling the outer line of a polygon.

@westnordost
Copy link
Author

But is there another way?

@pnorman
Copy link
Owner

pnorman commented Mar 8, 2024

Yes - a larger fill followed by a smaller inner, the same way we do casings on roads.

@westnordost
Copy link
Author

westnordost commented Mar 8, 2024

Oh, I have been using "line-gap-width" for the casing. But anyway, when using two fill layers with one of them being slightly offset to be smaller, it sounds like it would result in the same rendering as when using an offset line for the "shore".

@pnorman pnorman transferred this issue from pnorman/tilekiln Mar 13, 2024
@pnorman pnorman added the shortbread Issues with the supplied shortbread implementation label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shortbread Issues with the supplied shortbread implementation
Projects
None yet
Development

No branches or pull requests

2 participants