From 6ca6522b5cb0f502681701e07d70879d13e19794 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 5 Nov 2024 11:16:47 -0500 Subject: [PATCH 01/10] Fixed section 21 message errors --- .../ashrae9012019/section21/section21rule1.py | 11 ++++++----- .../ashrae9012019/section21/section21rule2.py | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/rct229/rulesets/ashrae9012019/section21/section21rule1.py b/rct229/rulesets/ashrae9012019/section21/section21rule1.py index 1db5423297..2b1c7717f4 100644 --- a/rct229/rulesets/ashrae9012019/section21/section21rule1.py +++ b/rct229/rulesets/ashrae9012019/section21/section21rule1.py @@ -27,11 +27,8 @@ def __init__(self): standard_section="Section G3.1.1.3 Baseline HVAC System Requirements for Systems Utilizing Purchased " "Chilled Water and/or Purchased Heat", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Proposed is modeled with purchased hot water or steam. " - "Make sure the heating source in the baseline building is also purchased hot water or steam.", - not_applicable_msg="Rule 21-1 Not Applicable - the proposed is not modeled with Purchased Hot Water or " - "Steam", + list_path="ruleset_model_descriptions[0]" + ) class RulesetModelInstanceRule(PartialRuleDefinition): @@ -40,6 +37,10 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=False, PROPOSED=True ), + manual_check_required_msg="Manual Check Required - Proposed is modeled with purchased hot water or steam. " + "Make sure the heating source in the baseline building is also purchased hot water or steam.", + not_applicable_msg="Rule 21-1 Not Applicable - the proposed is not modeled with Purchased Hot Water or " + "Steam", ) def applicability_check(self, context, calc_vals, data): diff --git a/rct229/rulesets/ashrae9012019/section21/section21rule2.py b/rct229/rulesets/ashrae9012019/section21/section21rule2.py index 433c3225fa..2d52a5b01f 100644 --- a/rct229/rulesets/ashrae9012019/section21/section21rule2.py +++ b/rct229/rulesets/ashrae9012019/section21/section21rule2.py @@ -24,11 +24,8 @@ def __init__(self): standard_section="Section G3.1.1.3 Baseline HVAC System Requirements for Systems Utilizing Purchased " "Chilled Water and/or Purchased Heat", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Proposed is modeled with purchased hot water or steam. " - "Make sure the baseline model uses the same number of pumps for the heating loop.", - not_applicable_msg="Rule 21-1 Not Applicable - the proposed is not modeled with Purchased Hot Water or " - "Steam", + list_path="ruleset_model_descriptions[0]" + ) class RulesetModelInstanceRule(PartialRuleDefinition): @@ -37,6 +34,10 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=False, PROPOSED=True ), + manual_check_required_msg="Manual Check Required - Proposed is modeled with purchased hot water or steam. " + "Make sure the baseline model uses the same number of pumps for the heating loop.", + not_applicable_msg="Rule 21-2 Not Applicable - the proposed is not modeled with Purchased Hot Water or " + "Steam" ) def applicability_check(self, context, calc_vals, data): From ad24bb8b284e5c2cd1ed3eb374f8ad858f2bf41f Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 5 Nov 2024 11:17:19 -0500 Subject: [PATCH 02/10] Fixed section 22 raised message errors. --- .../ashrae9012019/section22/section22rule35.py | 10 +++++----- .../ashrae9012019/section22/section22rule37.py | 10 +++++----- .../ashrae9012019/section22/section22rule38.py | 13 +++++++------ .../ashrae9012019/section22/section22rule39.py | 9 +++++---- 4 files changed, 22 insertions(+), 20 deletions(-) diff --git a/rct229/rulesets/ashrae9012019/section22/section22rule35.py b/rct229/rulesets/ashrae9012019/section22/section22rule35.py index 013795fad5..f3a7a8ddf8 100644 --- a/rct229/rulesets/ashrae9012019/section22/section22rule35.py +++ b/rct229/rulesets/ashrae9012019/section22/section22rule35.py @@ -23,11 +23,7 @@ def __init__(self): ruleset_section_title="HVAC - Chiller", standard_section="Section G3.1.3.10 Chilled-Water Pumps (Systems 7, 8, 11, 12, and 13)", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make" - "sure baseline systems served by purchased chilled water are not modeled with chilled water reset.", - not_applicable_msg="Rule 22-35 Not Applicable - the baseline is not modeled with Purchased Chilled Water", - ) + list_path="ruleset_model_descriptions[0]") class RulesetModelInstanceRule(PartialRuleDefinition): def __init__(self): @@ -35,6 +31,10 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=True, PROPOSED=False ), + manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make " + "sure baseline systems served by purchased chilled water are not modeled with chilled water reset.", + not_applicable_msg="Rule 22-35 Not Applicable - the baseline is not modeled with Purchased Chilled Water", + ) def applicability_check(self, context, calc_vals, data): diff --git a/rct229/rulesets/ashrae9012019/section22/section22rule37.py b/rct229/rulesets/ashrae9012019/section22/section22rule37.py index 6126cdadad..fd0f1b6cee 100644 --- a/rct229/rulesets/ashrae9012019/section22/section22rule37.py +++ b/rct229/rulesets/ashrae9012019/section22/section22rule37.py @@ -23,11 +23,7 @@ def __init__(self): ruleset_section_title="HVAC - Chiller", standard_section="Section G3.1.3.10 Chilled-Water Pumps (Systems 7, 8, 11, 12, and 13)", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make " - "sure baseline systems served by purchased chilled water are modeled with a variable speed drive pump.", - not_applicable_msg="Rule 22-37 Not Applicable - the baseline is not modeled with Purchased Chilled Water", - ) + list_path="ruleset_model_descriptions[0]") class RulesetModelInstanceRule(PartialRuleDefinition): def __init__(self): @@ -35,6 +31,10 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=True, PROPOSED=False ), + manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make " + "sure baseline systems served by purchased chilled water are modeled with a variable speed drive pump.", + not_applicable_msg="Rule 22-37 Not Applicable - the baseline is not modeled with Purchased Chilled Water", + ) def applicability_check(self, context, calc_vals, data): diff --git a/rct229/rulesets/ashrae9012019/section22/section22rule38.py b/rct229/rulesets/ashrae9012019/section22/section22rule38.py index bff79ea207..653e64bfdc 100644 --- a/rct229/rulesets/ashrae9012019/section22/section22rule38.py +++ b/rct229/rulesets/ashrae9012019/section22/section22rule38.py @@ -23,12 +23,8 @@ def __init__(self): ruleset_section_title="HVAC - Chiller", standard_section="Section G3.1.3.10 Chilled-Water Pumps (Systems 7, 8, 11, 12, and 13)", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make sure " - "baseline systems served by purchased chilled water are modeled with the purchased chilled water loop having " - "a minimum flow setpoint of 25%.", - not_applicable_msg="Rule 22-38 Not Applicable - the baseline is not modeled with Purchased Chilled Water", - ) + list_path="ruleset_model_descriptions[0]" + ) class RulesetModelInstanceRule(PartialRuleDefinition): def __init__(self): @@ -36,6 +32,11 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=True, PROPOSED=False ), + manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make sure " + "baseline systems served by purchased chilled water are modeled with the purchased chilled water loop having " + "a minimum flow setpoint of 25%.", + not_applicable_msg="Rule 22-38 Not Applicable - the baseline is not modeled with Purchased Chilled Water", + ) def applicability_check(self, context, calc_vals, data): diff --git a/rct229/rulesets/ashrae9012019/section22/section22rule39.py b/rct229/rulesets/ashrae9012019/section22/section22rule39.py index 52367279f0..34833eb97f 100644 --- a/rct229/rulesets/ashrae9012019/section22/section22rule39.py +++ b/rct229/rulesets/ashrae9012019/section22/section22rule39.py @@ -23,10 +23,7 @@ def __init__(self): ruleset_section_title="HVAC - Chiller", standard_section="Section G3.1.3.10 Chilled-Water Pumps (Systems 7, 8, 11, 12, and 13)", is_primary_rule=False, - list_path="ruleset_model_descriptions[0]", - manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make sure " - "baseline systems served by purchased chilled water are modeled with a distribution pump whose pump power is 16W/gpm.", - not_applicable_msg="Rule 22-39 Not Applicable - the baseline is not modeled with Purchased Chilled Water", + list_path="ruleset_model_descriptions[0]" ) class RulesetModelInstanceRule(PartialRuleDefinition): @@ -35,6 +32,10 @@ def __init__(self): rmds_used=produce_ruleset_model_description( USER=False, BASELINE_0=True, PROPOSED=False ), + manual_check_required_msg="Manual Check Required - Baseline is modeled with purchased chilled water. Make sure " + "baseline systems served by purchased chilled water are modeled with a distribution pump whose pump power is 16 W/gpm.", + not_applicable_msg="Rule 22-39 Not Applicable - the baseline is not modeled with Purchased Chilled Water", + ) def applicability_check(self, context, calc_vals, data): From 185f4fe6724dd8e406b6310fc8e87a4bdda0d324 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 5 Nov 2024 11:21:29 -0500 Subject: [PATCH 03/10] Fixed section 5 raised message errors --- rct229/rulesets/ashrae9012019/section5/section5rule28.py | 1 + rct229/rulesets/ashrae9012019/section5/section5rule37.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/rct229/rulesets/ashrae9012019/section5/section5rule28.py b/rct229/rulesets/ashrae9012019/section5/section5rule28.py index 4cd7f56f95..9b5e0c0c50 100644 --- a/rct229/rulesets/ashrae9012019/section5/section5rule28.py +++ b/rct229/rulesets/ashrae9012019/section5/section5rule28.py @@ -202,6 +202,7 @@ def __init__(self): "unit": "", } }, + manual_check_required_msg=MANUAL_CHECK_MSG, ) def is_applicable(self, context, data=None): diff --git a/rct229/rulesets/ashrae9012019/section5/section5rule37.py b/rct229/rulesets/ashrae9012019/section5/section5rule37.py index 1b039c0381..e6dfd9dedd 100644 --- a/rct229/rulesets/ashrae9012019/section5/section5rule37.py +++ b/rct229/rulesets/ashrae9012019/section5/section5rule37.py @@ -46,8 +46,7 @@ def __init__(self): standard_section="Section G3.1-5(b) Building Envelope Modeling Requirements for the Proposed design", is_primary_rule=True, list_path="ruleset_model_descriptions[0].buildings[*]", - data_items={"climate_zone": (PROPOSED, "weather/climate_zone")}, - manual_check_required_msg=MANUAL_CHECK_MSG, + data_items={"climate_zone": (PROPOSED, "weather/climate_zone")} ) class BuildingRule(RuleDefinitionBase): @@ -63,6 +62,7 @@ def __init__(self): "unit": "cfm", } }, + manual_check_required_msg=MANUAL_CHECK_MSG, ) def get_calc_vals(self, context, data=None): From b8daeb1c83a566ea05cff6cb9465661baff51e7b Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 12 Nov 2024 17:27:43 -0500 Subject: [PATCH 04/10] Add ruletest_engine updates for considering expected raised messages --- rct229/ruletest_engine/ruletest_engine.py | 41 +++++++++++++++++------ 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_engine.py b/rct229/ruletest_engine/ruletest_engine.py index 972abf0f73..d56df2d523 100644 --- a/rct229/ruletest_engine/ruletest_engine.py +++ b/rct229/ruletest_engine/ruletest_engine.py @@ -107,18 +107,22 @@ def evaluate_outcome_enumeration_str(outcome_enumeration_str): return test_result -def process_test_result(test_result, test_dict, test_id): +def process_test_result(test_result, raised_message, test_dict, test_id): """Returns a string describing whether or not a test resulted in its expected outcome Parameters ---------- test_result : str - String describing rule outcome. OPTIONS: 'pass', 'fail', 'undetermined' + String describing rule outcome. OPTIONS: 'pass', 'fail', 'undetermined', 'not_applicable' + + raised_message : str + + String describing any outcome or exception message from running the rule. test_dict : dict - Python dictionary containing the a test's expected outcome and description + Python dictionary containing the test's expected outcome and description test_id: str @@ -145,13 +149,23 @@ def process_test_result(test_result, test_dict, test_id): # Check if the test results agree with the expected outcome. Write an appropriate response based on their agreement received_expected_outcome = test_result == test_dict["expected_rule_outcome"] + #TODO - ask about tests where a raised message exists but is not captured. Code written to catch those. + + # Check for any raised message in the rule test. If none exists, return empty string "" + expected_raised_message = test_dict.get("expected_raised_message_includes", "") + + # Check if the raised message is a substring in the expected raised message (tests often don't have the full + # message) + messages_matched = expected_raised_message in raised_message + + # Success and failure tied to + overall_outcome = messages_matched and received_expected_outcome + # Check if the test results agree with the expected outcome. Write an appropriate response based on their agreement if received_expected_outcome: if test_result == "pass": - # f"SUCCESS: Test {test_id} passed as expected. The following condition was identified: {description}" outcome_text = "PASS" elif test_result == "fail": - # f"SUCCESS: Test {test_id} failed as expected. The following condition was identified: {description}" outcome_text = "FAIL" elif test_result == "undetermined": outcome_text = "UNDETERMINED" @@ -175,7 +189,14 @@ def process_test_result(test_result, test_dict, test_id): f"FAILURE: Test {test_id} returned '{test_result}' unexpectedly" ) - return outcome_text, received_expected_outcome + # Check if exception messages matched. If not, append that to the outcome message. + if not messages_matched: + outcome_text += (f"\rMessages did not match. Expected outcome message was '{expected_raised_message}' and " + f"instead received '{raised_message}'") + #outcome_text += f"\r'{expected_raised_message}' | '{raised_message}'" + + + return outcome_text, overall_outcome def run_section_tests( @@ -345,9 +366,6 @@ def run_section_tests( print("") # Buffer line - # Return whether or not all tests in this test JSON received their expected outcome as a boolean - all_tests_successful = all(test_result_dict["results"]) - return all_tests_pass @@ -660,9 +678,12 @@ def evaluate_outcome_object(outcome_dict, test_result_dict, test_dict, test_id): # (e.g., "PASSED" => "pass") test_result = evaluate_outcome_enumeration_str(outcome_enumeration_str) + # Check for any raised message in the outcome results. If none exists, return empty string "" + raised_message = outcome_dict.get("message", "") + # Write outcome text based and "receive_expected_outcome" boolean based on the test result outcome_text, received_expected_outcome = process_test_result( - test_result, test_dict, test_id + test_result, raised_message, test_dict, test_id ) # Append results if expected outcome not received From 963acdae1241c8d74e6c778f2f958441dacea257 Mon Sep 17 00:00:00 2001 From: Jackson Jarboe <122476654+JacksonJ-KC@users.noreply.github.com> Date: Fri, 15 Nov 2024 13:27:31 -0500 Subject: [PATCH 05/10] fixed 10-7 raised message error --- .../ashrae9012019/section10/rule_10_14.json | 206 +++++----- .../ashrae9012019/section10/rule_10_7.json | 161 ++++++-- .../section10_general_hvac_tcd_master.json | 367 +++++++++++------- 3 files changed, 464 insertions(+), 270 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_14.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_14.json index 2807488370..f3b1f4ebfb 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_14.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_14.json @@ -48,20 +48,20 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "efficiency_metric_values": [ 0.8 @@ -71,16 +71,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -145,20 +145,20 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4 @@ -168,16 +168,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -241,20 +241,20 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "rated_capacity": 58614.222222222226, "efficiency_metric_values": [ @@ -265,16 +265,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -338,20 +338,20 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.2 @@ -361,16 +361,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -434,21 +434,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 14653.555555555557 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4 @@ -458,16 +458,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -531,21 +531,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 14653.555555555557 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 2.3 @@ -555,16 +555,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -628,7 +628,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -636,14 +636,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -655,16 +655,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -728,7 +728,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -736,14 +736,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.1, @@ -755,16 +755,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -828,7 +828,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -836,14 +836,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -855,16 +855,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -928,7 +928,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -936,14 +936,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -955,16 +955,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1028,7 +1028,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1036,14 +1036,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 43960.666666666664 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1055,16 +1055,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1261,16 +1261,16 @@ "id": "System_9_Warm_Air_Furnace_Gas - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1", + "id": "System_9_Warm_Air_Furnace_Gas", "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "energy_source_type": "NATURAL_GAS", "efficiency_metric_values": [ @@ -1281,16 +1281,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Return Fan" } ] } @@ -1354,16 +1354,16 @@ "id": "System_9_Warm_Air_Furnace_Gas - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1", + "id": "System_9_Warm_Air_Furnace_Gas", "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "energy_source_type": "NATURAL_GAS", "efficiency_metric_values": [ @@ -1374,16 +1374,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Return Fan" } ] } @@ -1447,7 +1447,7 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ], "aggregation_factor": 5 @@ -1455,13 +1455,13 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "rated_capacity": 293071.1111111111, "efficiency_metric_values": [ @@ -1472,16 +1472,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -1545,21 +1545,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1571,16 +1571,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_7.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_7.json index e07c4f2c1e..38b328efb7 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_7.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10/rule_10_7.json @@ -47,7 +47,7 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ], "aggregation_factor": 1 @@ -55,9 +55,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 20514.977777777778, "efficiency_metric_values": [ @@ -68,20 +68,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -145,7 +145,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -153,9 +153,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 20514.977777777778, "efficiency_metric_values": [ @@ -166,20 +166,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -243,7 +243,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -251,9 +251,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 43960.666666666664, "efficiency_metric_values": [ @@ -264,20 +264,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -297,8 +297,106 @@ "Section": 10, "Rule": 7, "Test": "d", - "test_description": "A one story building includes a baseline system 4. The cooling capacity is undefined and the cooling efficiency of the system does not match the most conservative cooling efficiency from Table G3.5.2.", + "test_description": "A one story building includes a baseline system 4. The cooling capacity is 150 kBtu/hr and the cooling efficiency of the system does not match the expected efficiency based on the capacity range from Table G3.5.2.", "expected_rule_outcome": "fail", + "standard": { + "rule_id": "10-7", + "ruleset_reference": "G3.1.2.1", + "rule_description": "Baseline shall be modeled with the COPnfcooling HVAC system efficiency per Tables G3.5.1-G3.5.6. Where multiple HVAC zones or residential spaces are combined into a single thermal block the cooling efficiencies (for baseline HVAC System Types 3 and 4) shall be based on the equipment capacity of the thermal block divided by the number of HVAC zones or residential spaces. ", + "applicable_rmr": "Baseline Model", + "rule_assertion": "=", + "comparison_value": "Expected Value", + "mandatory_rule": "Yes", + "schema_version": "0.0.34" + }, + "rmd_transformations": { + "baseline": { + "id": "ASHRAE229 1", + "calendar": { + "is_leap_year": false + }, + "data_timestamp": "2024-02-12T12:00Z", + "ruleset_model_descriptions": [ + { + "id": "RMD 1", + "buildings": [ + { + "id": "Building 1", + "building_open_schedule": "Required Building Schedule 1", + "building_segments": [ + { + "id": "Building Segment 1", + "zones": [ + { + "id": "Thermal Zone 1", + "floor_name": "Floor1", + "spaces": [ + { + "id": "Space 1", + "floor_area": 929.0303999999999 + } + ], + "terminals": [ + { + "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", + "is_supply_ducted": true, + "type": "CONSTANT_AIR_VOLUME", + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" + } + ], + "aggregation_factor": 1 + } + ], + "heating_ventilating_air_conditioning_systems": [ + { + "id": "System_4_PSZ_HP", + "cooling_system": { + "id": "DX Coil 1", + "type": "DIRECT_EXPANSION", + "design_total_cool_capacity": 43960.666666666664, + "efficiency_metric_values": [ + 2.4 + ], + "efficiency_metric_types": [ + "FULL_LOAD_COEFFICIENT_OF_PERFORMANCE_NO_FAN" + ] + }, + "heating_system": { + "id": "HP Coil 1", + "type": "HEAT_PUMP" + }, + "fan_system": { + "id": "CAV Fan System 1", + "fan_control": "CONSTANT", + "supply_fans": [ + { + "id": "System_4_PSZ_HP Supply Fan" + } + ], + "return_fans": [ + { + "id": "System_4_PSZ_HP Return Fan" + } + ] + } + } + ] + } + ] + } + ], + "type": "BASELINE_0" + } + ] + } + } + }, + "rule-10-7-e": { + "Section": 10, + "Rule": 7, + "Test": "e", + "test_description": "A one story building includes a baseline system 4. The cooling capacity is undefined and the cooling efficiency of the system does not match the most conservative cooling efficiency from Table G3.5.2.", + "expected_rule_outcome": "undetermined", "expected_raised_message_includes": "The cooling capacity of the system could not be determined. Check if the modeled baseline DX cooling efficiency was established correctly based upon equipment capacity and type while accounting for the potential aggregation of zones.", "standard": { "rule_id": "10-7", @@ -342,18 +440,17 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", - "design_total_cool_capacity": 19049.329151111113, "efficiency_metric_values": [ 2.8 ], @@ -362,20 +459,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -391,10 +488,10 @@ } } }, - "rule-10-7-e": { + "rule-10-7-f": { "Section": 10, "Rule": 7, - "Test": "e", + "Test": "f", "test_description": "A two story building includes a baseline system 5. The system serves more than 1 floor.", "expected_rule_outcome": "not_applicable", "standard": { diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10_general_hvac_tcd_master.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10_general_hvac_tcd_master.json index 94180d13c4..db67317609 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10_general_hvac_tcd_master.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section10_general_hvac_tcd_master.json @@ -47,7 +47,7 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ], "aggregation_factor": 1 @@ -55,9 +55,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 20514.977777777778, "efficiency_metric_values": [ @@ -68,20 +68,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -145,7 +145,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -153,9 +153,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 20514.977777777778, "efficiency_metric_values": [ @@ -166,20 +166,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -243,7 +243,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -251,9 +251,9 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 43960.666666666664, "efficiency_metric_values": [ @@ -264,20 +264,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -297,8 +297,106 @@ "Section": 10, "Rule": 7, "Test": "d", - "test_description": "A one story building includes a baseline system 4. The cooling capacity is undefined and the cooling efficiency of the system does not match the most conservative cooling efficiency from Table G3.5.2.", + "test_description": "A one story building includes a baseline system 4. The cooling capacity is 150 kBtu/hr and the cooling efficiency of the system does not match the expected efficiency based on the capacity range from Table G3.5.2.", "expected_rule_outcome": "fail", + "standard": { + "rule_id": "10-7", + "ruleset_reference": "G3.1.2.1", + "rule_description": "Baseline shall be modeled with the COPnfcooling HVAC system efficiency per Tables G3.5.1-G3.5.6. Where multiple HVAC zones or residential spaces are combined into a single thermal block the cooling efficiencies (for baseline HVAC System Types 3 and 4) shall be based on the equipment capacity of the thermal block divided by the number of HVAC zones or residential spaces. ", + "applicable_rmr": "Baseline Model", + "rule_assertion": "=", + "comparison_value": "Expected Value", + "mandatory_rule": "Yes", + "schema_version": "0.0.34" + }, + "rmd_transformations": { + "baseline": { + "id": "ASHRAE229 1", + "calendar": { + "is_leap_year": false + }, + "data_timestamp": "2024-02-12T12:00Z", + "ruleset_model_descriptions": [ + { + "id": "RMD 1", + "buildings": [ + { + "id": "Building 1", + "building_open_schedule": "Required Building Schedule 1", + "building_segments": [ + { + "id": "Building Segment 1", + "zones": [ + { + "id": "Thermal Zone 1", + "floor_name": "Floor1", + "spaces": [ + { + "id": "Space 1", + "floor_area": 929.0303999999999 + } + ], + "terminals": [ + { + "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", + "is_supply_ducted": true, + "type": "CONSTANT_AIR_VOLUME", + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" + } + ], + "aggregation_factor": 1 + } + ], + "heating_ventilating_air_conditioning_systems": [ + { + "id": "System_4_PSZ_HP", + "cooling_system": { + "id": "DX Coil 1", + "type": "DIRECT_EXPANSION", + "design_total_cool_capacity": 43960.666666666664, + "efficiency_metric_values": [ + 2.4 + ], + "efficiency_metric_types": [ + "FULL_LOAD_COEFFICIENT_OF_PERFORMANCE_NO_FAN" + ] + }, + "heating_system": { + "id": "HP Coil 1", + "type": "HEAT_PUMP" + }, + "fan_system": { + "id": "CAV Fan System 1", + "fan_control": "CONSTANT", + "supply_fans": [ + { + "id": "System_4_PSZ_HP Supply Fan" + } + ], + "return_fans": [ + { + "id": "System_4_PSZ_HP Return Fan" + } + ] + } + } + ] + } + ] + } + ], + "type": "BASELINE_0" + } + ] + } + } + }, + "rule-10-7-e": { + "Section": 10, + "Rule": 7, + "Test": "e", + "test_description": "A one story building includes a baseline system 4. The cooling capacity is undefined and the cooling efficiency of the system does not match the most conservative cooling efficiency from Table G3.5.2.", + "expected_rule_outcome": "undetermined", "expected_raised_message_includes": "The cooling capacity of the system could not be determined. Check if the modeled baseline DX cooling efficiency was established correctly based upon equipment capacity and type while accounting for the potential aggregation of zones.", "standard": { "rule_id": "10-7", @@ -342,18 +440,17 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", - "design_total_cool_capacity": 19049.329151111113, "efficiency_metric_values": [ 2.8 ], @@ -362,20 +459,20 @@ ] }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP" }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -391,10 +488,10 @@ } } }, - "rule-10-7-e": { + "rule-10-7-f": { "Section": 10, "Rule": 7, - "Test": "e", + "Test": "f", "test_description": "A two story building includes a baseline system 5. The system serves more than 1 floor.", "expected_rule_outcome": "not_applicable", "standard": { @@ -579,20 +676,20 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "efficiency_metric_values": [ 0.8 @@ -602,16 +699,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -676,20 +773,20 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4 @@ -699,16 +796,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -772,20 +869,20 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "rated_capacity": 58614.222222222226, "efficiency_metric_values": [ @@ -796,16 +893,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -869,20 +966,20 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.2 @@ -892,16 +989,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -965,21 +1062,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 14653.555555555557 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4 @@ -989,16 +1086,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1062,21 +1159,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 14653.555555555557 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 2.3 @@ -1086,16 +1183,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1159,7 +1256,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1167,14 +1264,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1186,16 +1283,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1259,7 +1356,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1267,14 +1364,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.1, @@ -1286,16 +1383,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1359,7 +1456,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1367,14 +1464,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1386,16 +1483,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1459,7 +1556,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1467,14 +1564,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1486,16 +1583,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1559,7 +1656,7 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ], "aggregation_factor": 1 @@ -1567,14 +1664,14 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 43960.666666666664 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -1586,16 +1683,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } @@ -1792,16 +1889,16 @@ "id": "System_9_Warm_Air_Furnace_Gas - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1", + "id": "System_9_Warm_Air_Furnace_Gas", "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "energy_source_type": "NATURAL_GAS", "efficiency_metric_values": [ @@ -1812,16 +1909,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Return Fan" } ] } @@ -1885,16 +1982,16 @@ "id": "System_9_Warm_Air_Furnace_Gas - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_9_Warm_Air_Furnace_Gas" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_9_Warm_Air_Furnace_Gas Thermal Zone 1", + "id": "System_9_Warm_Air_Furnace_Gas", "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "energy_source_type": "NATURAL_GAS", "efficiency_metric_values": [ @@ -1905,16 +2002,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_9_Warm_Air_Furnace_Gas Return Fan" } ] } @@ -1978,7 +2075,7 @@ "id": "System_3_PSZ_AC_Gas_Furnace - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_3_PSZ_AC_Gas_Furnace" } ], "aggregation_factor": 5 @@ -1986,13 +2083,13 @@ ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_3_PSZ_AC_Gas_Furnace Thermal Zone 1", + "id": "System_3_PSZ_AC_Gas_Furnace", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION" }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "Furnace Coil 1", "type": "FURNACE", "rated_capacity": 293071.1111111111, "efficiency_metric_values": [ @@ -2003,16 +2100,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_3_PSZ_AC_Gas_Furnace Return Fan" } ] } @@ -2076,21 +2173,21 @@ "id": "System_4_PSZ_HP - Terminal for Thermal Zone 1", "is_supply_ducted": true, "type": "CONSTANT_AIR_VOLUME", - "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP Thermal Zone 1" + "served_by_heating_ventilating_air_conditioning_system": "System_4_PSZ_HP" } ] } ], "heating_ventilating_air_conditioning_systems": [ { - "id": "System_4_PSZ_HP Thermal Zone 1", + "id": "System_4_PSZ_HP", "cooling_system": { - "id": "Cooling Sys - Thermal Zone 1", + "id": "DX Coil 1", "type": "DIRECT_EXPANSION", "design_total_cool_capacity": 23445.68888888889 }, "heating_system": { - "id": "Heating Sys - Thermal Zone 1", + "id": "HP Coil 1", "type": "HEAT_PUMP", "efficiency_metric_values": [ 3.4, @@ -2102,16 +2199,16 @@ ] }, "fan_system": { - "id": "Fan System - Thermal Zone 1", + "id": "CAV Fan System 1", "fan_control": "CONSTANT", "supply_fans": [ { - "id": "Supply Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Supply Fan" } ], "return_fans": [ { - "id": "Return Fan - Thermal Zone 1" + "id": "System_4_PSZ_HP Return Fan" } ] } From a8819817a5539d069d4f3fe6e6819970d134dabc Mon Sep 17 00:00:00 2001 From: Jackson Jarboe <122476654+JacksonJ-KC@users.noreply.github.com> Date: Fri, 15 Nov 2024 13:35:26 -0500 Subject: [PATCH 06/10] fixed rule4-1 raised message error --- rct229/rulesets/ashrae9012019/section4/section4rule1.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rct229/rulesets/ashrae9012019/section4/section4rule1.py b/rct229/rulesets/ashrae9012019/section4/section4rule1.py index 2b63c9c61c..282ed1f342 100644 --- a/rct229/rulesets/ashrae9012019/section4/section4rule1.py +++ b/rct229/rulesets/ashrae9012019/section4/section4rule1.py @@ -18,7 +18,7 @@ ZCC.CONDITIONED_RESIDENTIAL, ] MANUAL_CHECK_MSG = ( - "There is a temperature schedule mismatch between the baseline and proposed rmds. Fail unless " + "There is a temperature schedule mismatch between the baseline and proposed. Fail unless " "Table G3.1 #4 baseline column exception #s 1 and/or 2 are applicable " ) From fc27d9bf67e53bae7f77be1d02741b24a0d59c44 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 19 Nov 2024 10:53:36 -0500 Subject: [PATCH 07/10] Typo in rule test 21-18-d --- .../ruletest_jsons/ashrae9012019/section21/rule_21_18.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section21/rule_21_18.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section21/rule_21_18.json index 41c3a43f4d..15f3609f6c 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section21/rule_21_18.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section21/rule_21_18.json @@ -446,7 +446,7 @@ "Test": "d", "test_description": "The project has one building segment with two zones served by a baseline system type 7 with a hot water loop. The hot water boiler uses propane as the fuel source.", "expected_rule_outcome": "undetermined", - "expected_raised_message_includes": "Basline boiler fuel source is modeled as propane. Verify if natural gas is not available for the proposed building site as determined by the rating authority.", + "expected_raised_message_includes": "Baseline boiler fuel source is modeled as propane. Verify if natural gas is not available for the proposed building site as determined by the rating authority.", "standard": { "rule_id": "21-18", "ruleset_reference": "G3.1.2.1", From d968a11e3a035c84ad003af9c627639cc313f304 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 19 Nov 2024 17:26:34 -0500 Subject: [PATCH 08/10] Fixed typos in expected text for rule tests 19-33 and 19-34. --- .../ashrae9012019/section19/rule_19_33.json | 22 ++----------------- .../ashrae9012019/section19/rule_19_34.json | 20 +---------------- 2 files changed, 3 insertions(+), 39 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_33.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_33.json index 2bc2a0d4ea..1b668e7a7c 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_33.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_33.json @@ -5,7 +5,7 @@ "Test": "a", "test_description": "The project has one building segment with one zone. The zone does not have a cooling system in the user model, and is served by a packaged terminal air conditioner in the proposed.", "expected_rule_outcome": "undetermined", - "expected_raised_message_includes": "is only being simulated in the P_RMI to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the heating and/or cooling system fans are simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD the fan associated with", + "expected_raised_message_includes": "is only being simulated in the proposed model to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the heating and/or cooling system fans are simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD the fan associated with", "standard": { "rule_id": "19-33", "ruleset_reference": "Table G3.1 Section 4 Exception #1", @@ -26,15 +26,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -98,15 +95,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -170,7 +164,7 @@ "Test": "b", "test_description": "The project has one building segment with one zone. The zone does not have a heating system in the user model, and is served by a hot water coil in the proposed.", "expected_rule_outcome": "undetermined", - "expected_raised_message_includes": "is only being simulated in the P_RMI to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the heating and/or cooling system fans are simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD the fan associated with", + "expected_raised_message_includes": "is only being simulated in the proposed model to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the heating and/or cooling system fans are simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD the fan associated with", "standard": { "rule_id": "19-33", "ruleset_reference": "Table G3.1 Section 4 Exception #1", @@ -191,15 +185,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -263,15 +254,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -355,15 +343,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -427,15 +412,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_34.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_34.json index bf441eabc5..ee58d114f5 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_34.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_34.json @@ -5,7 +5,7 @@ "Test": "a", "test_description": "The project has one building segment with one zone. The zone does not have a cooling system in the user model, and is served by a packaged terminal air conditioner in the baseline.", "expected_rule_outcome": "undetermined", - "expected_raised_message_includes": "is only being simulated in the P_RMI to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the hvac system fan is simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD the fan associated with", + "expected_raised_message_includes": "is only being simulated in the proposed model to meet the requirements described in Section G3.1-10 HVAC Systems proposed column c and d for heating and/or cooling. Check that the hvac system fan is simulated to be cycled ON and OFF to meet heating and/or cooling loads during occupied hours as applicable. Note that per the RMD, the fan associated with", "standard": { "rule_id": "19-34", "ruleset_reference": "Table G3.1 Section 4 Exception #1", @@ -26,15 +26,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -104,15 +101,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -182,15 +176,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -280,15 +271,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -358,15 +346,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", @@ -436,15 +421,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "PTAC Terminal 1", From f7f86ccd21839e9f901a0225d9ab5317ba46c808 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Tue, 19 Nov 2024 18:05:18 -0500 Subject: [PATCH 09/10] Fix for 19-36. Typos in dict keys (e.g., outdoor_air_flow should have been outdoor_airflow) in applicability test. Additionally the test itself had incorrect values. Updated the test description and unit test to agree with intent of ruletest. --- .../section19/section19rule36.py | 4 +-- .../ashrae9012019/section19/rule_19_36.json | 28 +++---------------- 2 files changed, 6 insertions(+), 26 deletions(-) diff --git a/rct229/rulesets/ashrae9012019/section19/section19rule36.py b/rct229/rulesets/ashrae9012019/section19/section19rule36.py index b3b80b168b..6d1a0dd0d5 100644 --- a/rct229/rulesets/ashrae9012019/section19/section19rule36.py +++ b/rct229/rulesets/ashrae9012019/section19/section19rule36.py @@ -64,10 +64,10 @@ def get_calc_vals(self, context, data=None): energy_recovery_b, "air_energy_recovery", "design_latent_effectiveness" ) ERV_OA_airflow_b = getattr_( - energy_recovery_b, "air_energy_recovery", "outside_air_flow" + energy_recovery_b, "air_energy_recovery", "outdoor_airflow" ) ERV_EA_airflow_b = getattr_( - energy_recovery_b, "air_energy_recovery", "exhaust_air_flow" + energy_recovery_b, "air_energy_recovery", "exhaust_airflow" ) hvac_min_oa_flow_b = getattr_( hvac_b, "HVAC", "fan_system", "minimum_outdoor_airflow" diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_36.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_36.json index 567a1185aa..9f2bf0aa00 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_36.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section19/rule_19_36.json @@ -3,7 +3,7 @@ "Section": 19, "Rule": 36, "Test": "a", - "test_description": "The project has one building segment with two zones served by a baseline system type 7. The supply fan capacity is greater than 5,000 CFM and the minimum outside air ratio is greater than 70%. The baseline HVAC system has an ERV with an enthalpy recovery ratio greater than 50%.", + "test_description": "The project has one building segment with two zones served by a baseline system type 7. The supply fan capacity is greater than 5,000 CFM and the minimum outside air ratio equal to 50%. The baseline HVAC system has an ERV with an enthalpy recovery ratio equal to 50%.", "expected_rule_outcome": "undetermined", "expected_raised_message_includes": "Verify that it is equivalent to 50% enthalpy recovery ratio required by G3.1.2.10.", "standard": { @@ -26,15 +26,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 1", @@ -48,8 +45,6 @@ }, { "id": "Thermal Zone 2", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 2", @@ -154,15 +149,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 1", @@ -176,8 +168,6 @@ }, { "id": "Thermal Zone 2", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 2", @@ -218,14 +208,14 @@ "design_airflow": 4719.474431999998 } ], - "minimum_outdoor_airflow": 3303.6321023999985, + "minimum_outdoor_airflow": 2359.737215999999, "maximum_outdoor_airflow": 4719.474431999998, "air_energy_recovery": { "id": "Air Energy Recovery 1", - "outdoor_airflow": 4719.474431999998, + "outdoor_airflow": 2359.737215999999, "design_sensible_effectiveness": 0.5, "design_latent_effectiveness": 0.5, - "exhaust_airflow": 4719.474431999998, + "exhaust_airflow": 2359.737215999999, "enthalpy_recovery_ratio": 0.5 } } @@ -313,15 +303,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 1", @@ -335,8 +322,6 @@ }, { "id": "Thermal Zone 2", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 2", @@ -441,15 +426,12 @@ "buildings": [ { "id": "Building 1", - "building_open_schedule": "Required Building Schedule 1", "building_segments": [ { "id": "Building Segment 1", "zones": [ { "id": "Thermal Zone 1", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 1", @@ -463,8 +445,6 @@ }, { "id": "Thermal Zone 2", - "thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1", - "thermostat_heating_setpoint_schedule": "Required Heating Schedule 1", "terminals": [ { "id": "VAV Air Terminal 2", From faf410b30cf4c48834ef7410aaf35cd6327b397b Mon Sep 17 00:00:00 2001 From: gonz102 Date: Wed, 20 Nov 2024 10:02:31 -0500 Subject: [PATCH 10/10] black formatting --- rct229/ruletest_engine/ruletest_engine.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_engine.py b/rct229/ruletest_engine/ruletest_engine.py index d56df2d523..061bf7dd25 100644 --- a/rct229/ruletest_engine/ruletest_engine.py +++ b/rct229/ruletest_engine/ruletest_engine.py @@ -1,13 +1,12 @@ import glob import json -from typing import Optional # from jsonpointer import JsonPointer import os from copy import deepcopy +from typing import Optional from pint import Quantity - from rct229.reports.ashrae9012019.ashrae901_2019_software_test_report import ( ASHRAE9012019SoftwareTestReport, ) @@ -149,7 +148,7 @@ def process_test_result(test_result, raised_message, test_dict, test_id): # Check if the test results agree with the expected outcome. Write an appropriate response based on their agreement received_expected_outcome = test_result == test_dict["expected_rule_outcome"] - #TODO - ask about tests where a raised message exists but is not captured. Code written to catch those. + # TODO - ask about tests where a raised message exists but is not captured. Code written to catch those. # Check for any raised message in the rule test. If none exists, return empty string "" expected_raised_message = test_dict.get("expected_raised_message_includes", "") @@ -191,10 +190,10 @@ def process_test_result(test_result, raised_message, test_dict, test_id): # Check if exception messages matched. If not, append that to the outcome message. if not messages_matched: - outcome_text += (f"\rMessages did not match. Expected outcome message was '{expected_raised_message}' and " - f"instead received '{raised_message}'") - #outcome_text += f"\r'{expected_raised_message}' | '{raised_message}'" - + outcome_text += ( + f"\rMessages did not match. Expected outcome message was '{expected_raised_message}' and " + f"instead received '{raised_message}'" + ) return outcome_text, overall_outcome