Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json Test for Section 22 Rule 19 #1097

Open
weilixu opened this issue May 24, 2023 · 1 comment
Open

Json Test for Section 22 Rule 19 #1097

weilixu opened this issue May 24, 2023 · 1 comment
Assignees

Comments

@weilixu
Copy link
Collaborator

weilixu commented May 24, 2023

After reading the RDS, json test and other materials, I believe the json test is defined incorrectly.

The loop in the HeatRejection object shall point to a fluid_loop that is dedicated to the heat rejection device.
Instead, the json test point to the secondary loop of the cooling loop.

The rule 19 is checking the temperature_reset_type for a heat_rejection loop is set to CONSTANT, but the secondary loop (child_loop) for a cooling loop has a temperature_reset_type of OUTSIDE_AIR_RESET according to Rule 22-3

To correct it, you will need to create a new fluid_loop that is for heat rejection, and add this loop id to chiller/condensing_loop

@JacksonJ-KC
Copy link
Collaborator

This issue appears to have been addressed. All heat_rejection's loop point to the Condenser Loop 1 and not the Secondary CHW Loop 1 and the expected outcomes are being received for rules 22-19 and 22-3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants