Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tonemapping"/colors issues for some demos #11

Open
abernier opened this issue Jul 23, 2024 · 2 comments
Open

"tonemapping"/colors issues for some demos #11

abernier opened this issue Jul 23, 2024 · 2 comments

Comments

@abernier
Copy link
Member

abernier commented Jul 23, 2024

https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791

list all <r152 and upgrade them

TODO: list them here

@abernier abernier changed the title color/ligntening issues for some demos "tonemapping" issues for some demos Aug 1, 2024
@rndexe
Copy link
Contributor

rndexe commented Aug 1, 2024

I feel there are other lighting related changes as well such as in arkanoid-under-60-loc which are not related to tonemapping.

In general things are a bit darker and colors appear more dull.

@abernier abernier changed the title "tonemapping" issues for some demos "tonemapping"/colors changes for some demos Aug 1, 2024
@abernier abernier changed the title "tonemapping"/colors changes for some demos "tonemapping"/colors issues for some demos Aug 1, 2024
@abernier abernier mentioned this issue Aug 1, 2024
29 tasks
@krispya
Copy link
Member

krispya commented Aug 1, 2024

The lighting model changed. To get lights to be about the same intensity you take the old value and multiply by PI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants