Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix GitHub binary upload using dotnet-tools #78

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

pleonex
Copy link
Owner

@pleonex pleonex commented Nov 23, 2023

Fix task UploadReleaseBinariesTask using dotnet-tool instead of Cake extension as it cannot locate the binary.

Tested manually with template-csharp this time.

Quality check list

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

  • The task can upload one or more files to a GitHub release.

Follow-up work

Update template-csharp and release.

Example

None

@pleonex pleonex merged commit 0b5849b into main Nov 23, 2023
4 checks passed
@pleonex pleonex deleted the feature/fix-uploadbin branch November 23, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant