Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge tutorials (eliminate duplication) #84

Open
ignasi35 opened this issue Jan 10, 2020 · 0 comments
Open

Converge tutorials (eliminate duplication) #84

ignasi35 opened this issue Jan 10, 2020 · 0 comments

Comments

@ignasi35
Copy link
Member

ignasi35 commented Jan 10, 2020

We have multiple copies of tutorial/starter content. Some of that content is in the the play-xxx-start-example some of the content is in https://www.playframework.com/documentation/2.8.x/HelloWorldTutorial (backed by https://github.com/playframework/playframework/blob/master/documentation/manual/tutorial/HelloWorldTutorial.md).

Each writeup includes snippets maintained on each of the repos. The snippets not only are duplicate across repos, but the twirl templates are also duplicate between the play-xxx-start-example samples.

The welcome.scala.html templates also include introductions/tutorial contents and even copy/pasted snippets from the HomeController and the main.scala.html.

Summing up, as an example, a change in main.scala.html requires sync'ing code in 5 places:

  • 2x twirl templates on each of the samples
  • 2x welcome pages on each of the samples
  • 1x on the snippets of the documentation backing playframework.com's tutorial
@dwijnand dwijnand removed the triage label Jan 10, 2020
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
```
Updated with template-control on 2019-01-17T15:10:57.482Z
  /.mergify.yml:
    wrote /.mergify.yml

```
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
…2.6.x

Upgrade branch 2.6.x using TemplateControl
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
* play-java-jpa-example/2.6.x: (48 commits)
  Nest play-java-jpa-example
  Updated with template-control on 2019-02-13T20:25:39.298Z (playframework#87)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#84)
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  Updated with template-control on 2019-01-08T14:44:42.531Z (playframework#81)
  Updated with template-control on 2019-01-04T17:13:23.827Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Updated with template-control on 2018-09-11T20:14:50.333Z (playframework#65)
  Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#63)
  Updated with template-control on 2018-07-19T01:58:55.873Z (playframework#61)
  Updated with template-control on 2018-07-16T18:38:45.441Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  Updated with template-control on 2018-05-27T23:54:09.603Z (playframework#58)
  Updated with template-control on 2018-04-06T19:34:58.092Z (playframework#55)
  Updated with template-control on 2018-03-02T18:56:28.087Z (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  Fix cross build to sbt 1.1.0 (playframework#52)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
… 2.6.x

* play-java-websocket-example/2.6.x: (83 commits)
  Nest play-java-websocket-example
  Updated with template-control on 2019-02-13T20:25:39.721Z (playframework#100)
  Upgrade branch 2.6.x using TemplateControl (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Updated with template-control on 2019-01-08T14:44:42.192Z (playframework#90)
  Updated with template-control on 2019-01-04T17:13:23.935Z (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#84)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  Updated with template-control on 2018-09-11T20:14:50.523Z (playframework#79)
  Updated with template-control on 2018-08-20T20:37:13.896Z (playframework#78)
  Updated with template-control on 2018-07-19T01:58:55.842Z (playframework#76)
  Updated with template-control on 2018-07-16T18:38:45.656Z (playframework#75)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Updated with template-control on 2018-05-27T23:54:09.712Z (playframework#73)
  Updated with template-control on 2018-04-06T19:34:58.514Z (playframework#71)
  Updated with template-control on 2018-03-02T18:56:28.527Z (playframework#70)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Fix cross build to sbt 1.1.0 (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#67)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
* play-scala-anorm-example/2.6.x: (68 commits)
  Nest play-scala-anorm-example
  Updated with template-control on 2019-02-13T20:25:39.764Z (playframework#105)
  Upgrade branch 2.6.x using TemplateControl (playframework#102)
  Upgrade branch 2.6.x using TemplateControl (playframework#101)
  Upgrade branch 2.6.x using TemplateControl (playframework#100)
  Updated with template-control on 2019-01-08T14:44:41.925Z (playframework#98)
  Updated with template-control on 2019-01-04T17:13:23.631Z (playframework#95)
  Fix deprecated WithResult.fold method usage (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#90)
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#89)
  Fix cross build to sbt 1.1.0 (playframework#76)
  Updated with template-control on 2018-07-19T01:58:55.836Z (playframework#87)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#86)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Updated with template-control on 2018-05-27T23:54:09.813Z (playframework#84)
  Updated with template-control on 2018-04-06T19:34:57.924Z (playframework#80)
  Update the README (playframework#82)
  Upgrade Anorm dependency and usage (playframework#81)
  link to playframework version of anorm (playframework#79)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
…' into 2.6.x

* play-scala-isolated-slick-example/2.6.x: (53 commits)
  Nest play-scala-isolated-slick-example
  Updated with template-control on 2019-02-13T20:25:39.661Z (playframework#84)
  Updated with template-control on 2019-02-01T10:40:33.042Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:58.033Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.882Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.929Z (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Remove JDK 9 & 10
  Updated with template-control on 2018-11-29T15:50:43.213Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Updated with template-control on 2018-10-08T19:11:41.295Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")
  Updated with template-control on 2018-09-11T20:14:50.342Z (playframework#68)
  Updated with template-control on 2018-08-20T19:30:29.032Z (playframework#67)
  Updated with template-control on 2018-07-19T01:58:56.035Z (playframework#65)
  Updated with template-control on 2018-07-16T18:38:45.677Z (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Updated with template-control on 2018-05-27T23:54:09.691Z (playframework#62)
  Updated with template-control on 2018-04-06T19:34:57.999Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#58)
  Fix cross build to sbt 1.1.0 (playframework#55)
  Update Play to version 2.6.10 (playframework#52)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants