Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After go-sql-driver/mysql is upgraded to >= 1.7.0, error message pattern should also be aligned #11787

Open
lance6716 opened this issue Nov 22, 2024 · 0 comments
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

What did you do?

Because after 1.7.0, go-sql-driver/mysql will add SQLState in error message, like Error 8004: Transaction is too large -> Error 8004 (HY000): Transaction is too large. Our hard-coded error pattern should also be updated

The problem is in release-6.5 go-sql-driver/mysql is updated https://github.com/pingcap/tiflow/blob/release-6.5/go.mod#L34 but UnsupportedDMLMsgs does not contain SQLState
https://github.com/pingcap/tiflow/blob/release-6.5/dm/pkg/retry/errors.go#L47

Maybe pick c46cd35 is enough

What did you expect to see?

No response

What did you see instead?

No response

Versions of the cluster

see below

current status of DM cluster (execute query-status <task-name> in dmctl)

DM v6.5.10, v6.5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant