Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu_cores_quota cause TiKV Panic #12479

Closed
nolouch opened this issue May 10, 2022 · 1 comment · Fixed by #12485 · May be fixed by pingcap/tidb-engine-ext#76
Closed

cpu_cores_quota cause TiKV Panic #12479

nolouch opened this issue May 10, 2022 · 1 comment · Fixed by #12485 · May be fixed by pingcap/tidb-engine-ext#76
Assignees
@tabokie
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.

Comments

@nolouch
Copy link
Contributor

nolouch commented May 10, 2022 •
edited
Loading

Bug Report

What version of TiKV are you using?

master 27bfe30

What operating system and CPU are you using?

CentOS 7.6; running in k8s, container runtime is docker.

Steps to reproduce

What did you expect?

no panic

What did happened?

 kubectl logs t1-tikv-0 -n csn
starting tikv-server ...
/tikv-server --pd=http://t1-pd:2379 --advertise-addr=t1-tikv-0.t1-tikv-peer.csn.svc:20160 --addr=0.0.0.0:20160 --status-addr=0.0.0.0:20180 --data-dir=/var/lib/tikv --capacity=200GB --config=/etc/tikv/tikv.toml

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', components/tikv_util/src/sys/cgroup.rs:263:44
stack backtrace:
   0: rust_begin_unwind
             at ./rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at ./rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/core/src/panicking.rs:143:14
   2: core::panicking::panic
             at ./rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/core/src/panicking.rs:48:5
   3: tikv_util::sys::cgroup::build_path
   4: tikv_util::sys::cgroup::CGroupSys::cpuset_cores
   5: tikv_util::sys::SysQuota::cpu_cores_quota
   6: <tikv::config::TiKvConfig as core::default::Default>::default
   7: <tikv::config::_IMPL_DESERIALIZE_FOR_TiKvConfig::<impl serde::de::Deserialize for tikv::config::TiKvConfig>::deserialize::__Visitor as serde::de::Visitor>::visit_map
   8: tikv::config::TiKvConfig::from_file
   9: tikv_server::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@tonyxuqqi
Copy link
Contributor

/cc @tabokie

@tabokie tabokie added type/bug The issue is confirmed as a bug. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 labels May 11, 2022
@tabokie tabokie mentioned this issue May 11, 2022
Merged
@zhangjinpeng87 zhangjinpeng87 added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label May 23, 2022
ti-chi-bot added a commit that referenced this issue May 24, 2022
@tabokie @ti-chi-bot
tikv_util: handle cgroup path building error (#12485)
456075a 
close #12479, ref #12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
This was referenced May 24, 2022
Closed
Merged
Merged
Closed
Merged
ti-chi-bot pushed a commit that referenced this issue May 25, 2022
@ti-srebot @tabokie
tikv_util: handle cgroup path building error (#12485) (#12634)
10ad17e 
close #12479, ref #12485, ref #12585

Handle cgroup path building error gracefully

Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Xinye Tao <[email protected]>
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tidb-engine-ext that referenced this issue Jun 1, 2022
@tabokie @ti-chi-bot @Lloyd-Pottiger
tikv_util: handle cgroup path building error (tikv#12485)
b8ccc3d 
close tikv#12479, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Jun 1, 2022
Closed
12 tasks
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tidb-engine-ext that referenced this issue Jun 1, 2022
@tabokie @ti-chi-bot @Lloyd-Pottiger
tikv_util: handle cgroup path building error (tikv#12485)
ce471e0 
close tikv#12479, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tidb-engine-ext that referenced this issue Jun 1, 2022
@tabokie @ti-chi-bot @Lloyd-Pottiger
tikv_util: handle cgroup path building error (tikv#12485)
2a0ab59 
close tikv#12479, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Jun 1, 2022
Merged
12 tasks
CalvinNeo pushed a commit to CalvinNeo/tidb-engine-ext that referenced this issue Jun 1, 2022
@tabokie @ti-chi-bot @CalvinNeo
tikv_util: handle cgroup path building error (tikv#12485)
5d8fb1c 
close tikv#12479, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@CalvinNeo CalvinNeo mentioned this issue Jun 1, 2022
Draft
12 tasks
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tidb-engine-ext that referenced this issue Jun 1, 2022
@tabokie @ti-chi-bot @Lloyd-Pottiger
tikv_util: handle cgroup path building error (tikv#12485)
acb622d 
close tikv#12479, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: tabokie <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Jun 1, 2022
Closed
12 tasks
ti-chi-bot added a commit that referenced this issue Jun 15, 2022
@ti-srebot @tabokie
@ti-chi-bot @glorv
tikv_util: handle cgroup path building error (#12485) (#12631)
c15f49c 
close #12479, ref #12485, ref #12585

Handle cgroup path building error gracefully

Signed-off-by: ti-srebot <[email protected]>
Signed-off-by: Xinye Tao <[email protected]>

Co-authored-by: Xinye Tao <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Co-authored-by: glorv <[email protected]>
ti-chi-bot added a commit that referenced this issue Jun 21, 2022
@ti-srebot @tabokie @ti-chi-bot
tikv_util: handle cgroup path building error (#12485) (#12632)
6a5404c 
close #12479, ref #12485, ref #12585

Handle cgroup path building error gracefully

Signed-off-by: ti-srebot <[email protected]>
Signed-off-by: Xinye Tao <[email protected]>
Signed-off-by: tabokie <[email protected]>

Co-authored-by: Xinye Tao <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
joccau pushed a commit to joccau/tikv that referenced this issue Jun 23, 2022
@ti-srebot @tabokie @joccau
tikv_util: handle cgroup path building error (tikv#12485) (tikv#12634)
02152b4 
close tikv#12479, ref tikv#12485, ref tikv#12585

Handle cgroup path building error gracefully

Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Xinye Tao <[email protected]>
Signed-off-by: joccau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabokie tabokie

Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
4 participants
@nolouch @tonyxuqqi @zhangjinpeng87 @tabokie