Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set callGasLimit on deployContract #274

Open
ctrlc03 opened this issue Aug 30, 2024 · 1 comment
Open

feat: allow to set callGasLimit on deployContract #274

ctrlc03 opened this issue Aug 30, 2024 · 1 comment

Comments

@ctrlc03
Copy link

ctrlc03 commented Aug 30, 2024

callGasLimit is a valid param for both 0.6 and 0.7 user operations, however it is not possible to specify this parameter when calling smart account actions such as deployContract (https://github.com/pimlicolabs/permissionless.js/blob/main/packages/permissionless/actions/smartAccount/deployContract.ts#L106) - could it be added to the args param please? This is blocking some work for us as we are not able to deploy larger contracts via a kernel account due to the call running out of gas. On the other hand, if I manually patch the lib to pass callGasLimit, I am able to deploy my contracts via the smart account.

@ctrlc03
Copy link
Author

ctrlc03 commented Sep 13, 2024

Resorted sending the user operation directly myself. Btw seems like when calldata gets too big, bundlers fail to estimate the correct gas limit required, so have to calculate using "prepareUserOperation" and add a 5-10% extra to be safe - not sure that's relevant still here

@ctrlc03 ctrlc03 closed this as completed Sep 13, 2024
@ctrlc03 ctrlc03 reopened this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant