Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squash commits #2

Open
obbardc opened this issue May 20, 2018 · 10 comments
Open

squash commits #2

obbardc opened this issue May 20, 2018 · 10 comments
Assignees

Comments

@obbardc
Copy link
Member

obbardc commented May 20, 2018

Once we are happy with our build of xwax, we should probably squash some of the commits to make it easier to rebase.

@danielhjames
Copy link
Member

Hi @obbardc I have added three commits to the touchscreen_gui branch since your rebase, compilation warnings are gone and BPMs are displayed correctly :-)

touchscreen_gui

@obbardc
Copy link
Member Author

obbardc commented May 23, 2018 via email

@danielhjames
Copy link
Member

Hi @obbardc I have updated the internal version number to 1.7-g(commit) by pulling the 1.7 tag from upstream xwax. The Debian package number can include 'pideck', which is a good idea since Debian is shipping 1.7 now.

@obbardc
Copy link
Member Author

obbardc commented May 25, 2018

Awesome, are you happy with the "touchscreen_gui" branch?

If so I will squash the commits.

@obbardc obbardc self-assigned this May 25, 2018
@danielhjames
Copy link
Member

I have just updated the readme files and changelog, I suggest I confirm that it builds and then you are welcome to squash it after that!

@danielhjames
Copy link
Member

With a few tweaks to the build instructions it worked, the package is in https://github.com/pideck/pideck-debs/tree/master/buster/armhf
I will check the binary package is functional on your latest testing image.

@obbardc
Copy link
Member Author

obbardc commented May 25, 2018

Awesome news, I'll squash the commits down after you've tested it on the current image

@obbardc
Copy link
Member Author

obbardc commented May 27, 2018

Hi @danielhjames I have compiled the image with the your compiled version of xwax.

It's here (as -beta) http://64studio.net/~chris/pideck/

To remove the double entries in the xwax list: rm /media/usb

The usbmount package still does not auto-rescan and also sometimes does work. This can be overcome be inserting the USB stick before booting. I've opened separate issues for these bugs.

Cheers!

@danielhjames
Copy link
Member

Nice! I have bought a new microSD card writer which should be more reliable than the one from Poundland :-) Also I have the CDJ here to test as I suspect the CD/vinyl buttons in the GUI are no longer needed in xwax 1.6 or 1.7.

@obbardc
Copy link
Member Author

obbardc commented May 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants