Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log cycling #57

Open
xxNpCxx opened this issue Jun 19, 2023 · 2 comments
Open

log cycling #57

xxNpCxx opened this issue Jun 19, 2023 · 2 comments

Comments

@xxNpCxx
Copy link

xxNpCxx commented Jun 19, 2023

Hey! There is a problem i was found at TelegramFetchCommand.php

while (true) {

    $response = rescue(fn() => $bot->handleGetUpdates($options));

    if ($response !== null && ! $response->isOk()) {
        $this->error($response->getDescription());
    }

}

setting timeout option doesn't delay while response will be ok . It means if you lost connection with db for some time, you got error log cycling.

@noplanman
Copy link
Member

@TiiFuchs Any thoughts? I'd need to dig in as I'm not familiar with this bit.

@TiiFuchs
Copy link
Member

TiiFuchs commented Sep 7, 2023

It means if you lost connection with db for some time, you got error log cycling.

Do you connect to a database yourself?
Since Laravel handles database connections quite well and the laravel package uses the db handler from Laravel, I would assume that it keeps it alive or reconnects automatically.

@xxNpCxx Do you have a suggestion to fix your problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants