Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double eslint validation error #326

Open
grayside opened this issue Sep 26, 2017 · 0 comments
Open

Double eslint validation error #326

grayside opened this issue Sep 26, 2017 · 0 comments
Labels
Milestone

Comments

@grayside
Copy link
Contributor

Problem

Gruntconfig.json has a theme top-level config, which itself is an object that has keys that match the name of the theme. This key is used to construct a path to the theme to blacklist paths for grunt validate to run the eslint checks. If this key does not match the path, grunt validate will run eslint using the theme's eslint configuration before attempting to run eslint via the theme.

Solution

Log an error if src/themes/ does not exist, in quality.js. There might be multiple places for that.

@grayside grayside added the bug label Sep 26, 2017
@grayside grayside added this to the 2.0.0 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant