Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review isNotExpression method for inlinings #847

Open
guillep opened this issue Aug 28, 2024 · 0 comments
Open

Review isNotExpression method for inlinings #847

guillep opened this issue Aug 28, 2024 · 0 comments

Comments

@guillep
Copy link
Member

guillep commented Aug 28, 2024

          I don't understand completely this:
  1. The method is negated (isNotExpression). It is more difficult to follow a negation than an affirmation. Would be nice to have an affirmative method and do the negation in the use: self isExpression not.
  2. This definition has sense for all TParseNode? Or only for TReturnNode (who call this method).
  3. I don't follow the condition anyway:
  • Why if the paren is nil is not an expression?
  • I understand that the only non-expression nodes are returns, assignments, (maybe if / case ?). Why is not asking that and is always asking for the parent?

Originally posted by @PalumboN in #836 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant