Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explanation of loading project baseline from local directory with gitlocal prefix #340

Open
Bajger opened this issue May 4, 2023 · 5 comments

Comments

@Bajger
Copy link

Bajger commented May 4, 2023

Currently section about loading MC project from local directory, contains just explanation of 2 prefixes: tonel, or filetree. See:

This snippet should be configured with:

{prefix}: This is specific to the file format:
filetree for a Filetree project
tonel for a Tonel project

But there is a 3rd option to use: gitlocal://prefix. How this is different to these two? Is gitlocalspecifying relative directory and implicit format is tonel?

@Bajger
Copy link
Author

Bajger commented May 4, 2023

@jecisc Hi Cyril! Can you comment add a reply here, if you have a knowledge of how gitlocal prefix works? I can update that section then and issue a PR. Thanks in advance!

@jecisc
Copy link
Member

jecisc commented May 4, 2023

Hi,
To be honest I never used this one. Here is the comment I found in the code:

Class: IceGitLocalRepositoryType
                                                                                                    
I resolve git local repositories (repositories already existing on your disk).
A gitlocal repositoy is composed of:

gitlocal://full/path/to/repository

gitlocal  		- The git local identifier
full/path/...	- This is a path to the place where the sources are.


For example, if you have a  repository in '/dev/voyage', which also has sources in subdirectory 'mc', your full path will be: '/dev/voyage/mc'. A part of my responsibilities is to find the git root  in the path provided.

Example:
------------
A script to install voyage using this would like more or less like this:

Metacello new
repository: 'gitlocal://Users/esteban/Dev/Repository/voyage/mc';
baseline: 'Voyage';
load: 'mongo tests'.

@cdlm
Copy link

cdlm commented May 5, 2023

I've used it with gitlocal://./subdir/ ; it's useful in terminal-based usage scenario:

$ git clone $GIT_URL_OF_PROJECT
$ cd $NAME_OF_PROJECT
$ run pharo from there (create image, load code… as it should be)

@Bajger
Copy link
Author

Bajger commented May 6, 2023

So I would assume, semantically it does not look anyhow different to tonel or filetree prefix (it just loads local repo based on relative or absolute path), and probably it uses default Iceberg setting for file format?

@jecisc
Copy link
Member

jecisc commented May 6, 2023

I guess.

so it need to be a GitHub repo and not a standalone folder with sources, but you don’t have to care about the format it seems. We can add that to the doc. I’ll try to do it at some point today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants