Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or enable direct labelling of curves #10

Open
bailliem opened this issue Jul 31, 2022 · 3 comments
Open

Add or enable direct labelling of curves #10

bailliem opened this issue Jul 31, 2022 · 3 comments
Assignees

Comments

@bailliem
Copy link
Collaborator

Provide support to direct label survival curves instead of a legend. Two strata with risk table is ok, but more then its a lot of work to map which line goes with which row in the risk table etc. Direct labelling with additional encoding (u.e. colour) to support the reader would be an elegant solution.

Things to discuss:

  • Do we provide a function or is there a ggplot2 package that supports this directly so we don't need to?
  • Can we extend/borrow existing attempts such as here https://ggobi.github.io/ggally/articles/ggsurv.html
  • How are lines, legends and risk tables all aesthetically designed to be informative and consistent? Using colour, fonts, ordering, etc to support?
@ddsjoberg
Copy link
Collaborator

In the ggsurv package, they leave it to the user to manually add the labels with ggplot2::annotate(), which our users can do as well. I think it will be very difficult to provide a better UI than the ggplot function.

@ddsjoberg ddsjoberg transferred this issue from another repository Aug 4, 2022
@ddsjoberg
Copy link
Collaborator

@bailliem will add an example of this to the gallery.

@ddsjoberg
Copy link
Collaborator

@bailliem hey hey! is this something you're still planning on doing?

@ddsjoberg ddsjoberg added this to the Release v1.0.0 milestone Sep 30, 2023
@ddsjoberg ddsjoberg removed this from the Release v1.0.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants