Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SISTR in IRIDA #196

Closed
7 of 16 tasks
apetkau opened this issue Nov 21, 2018 · 2 comments
Closed
7 of 16 tasks

Update SISTR in IRIDA #196

apetkau opened this issue Nov 21, 2018 · 2 comments
Labels
tools Pipelines and workflows in IRIDA

Comments

@apetkau
Copy link
Member

apetkau commented Nov 21, 2018

Additions for SISTR

Most of these have been incorporated into the latest SISTR release SISTR v1.1.1.

Integrate SISTR into IRIDA

  • Update SISTR tool in Galaxy to version 1.1.1 (latest release).
  • Incorporate newest version of the IRIDA/SISTR pipeline (pipeline files here) - [Edit: this will be done as a plugin]
  • Update SISTR results in IRIDA UI.
    • Update SISTR results page (in particular to show additional information such as loci found in addition to alleles found). An example of what this page looks like is here.
    • The main source file is here but here may be other files to update to get it working.
  • Update the SISTR pipeline documentation in IRIDA with any new changes (e.g., description of output files or screenshots).
  • [ ] Update IRIDA Galaxy Docker with latest tools. This is better left for the update SNVPhyl issue since I have to update the Docker image there too (and I was already working on it). Will be solved in Change SNVPhyl dependency to use main Galaxy toolshed #713
  • Test updated SISTR pipeline to make sure it returns the correct results for some datasets (I'm not sure which dataset to use or how necessary since I'm not sure if people have already tested the SISTR command-line application).

Additional tasks

  • Update the irida-sistr-results command-line tool to include new fields produced by SISTR Update output for newest SISTR release irida-sistr-results#13. This task can be done independently of an IRIDA release. It also depends on if people still use this program to extract SISTR results (or if they used the metadata/linelist table).
@apetkau apetkau self-assigned this Nov 21, 2018
@apetkau apetkau added the tools Pipelines and workflows in IRIDA label Nov 21, 2018
@apetkau apetkau changed the title Update SISTR results to contain additional information Update SISTR in IRIDA Jul 24, 2020
@apetkau apetkau removed their assignment Jul 24, 2020
@kbessonov1984
Copy link
Contributor

kbessonov1984 commented Aug 12, 2020

Current updates as of today Aug 12, 2020:

  • The objective Update SISTR tool in Galaxy to version 1.1.1 (latest release) is complete. Galaxy has now the newest version of SISTR v1.1.1
  • Incorporate newest version of the IRIDA/SISTR pipeline is complete.
    • Galaxy Project workflow updated with
      *Minimum contig length set to 1 bp in shovill parameters
      • Shovill updated to version 1.1.0+galaxy0
        * SISTR Sample Updater in now outputs new fields in the IRIDA project metadata
  • IRIDA SISTR Plugin is released with install instructions link

@tom114
Copy link
Contributor

tom114 commented Jun 1, 2021

Now that SISTR has been externalized into a plugin at https://github.com/phac-nml/irida-plugin-sistr, we're targeting to remove the built-in SISTR from IRIDA. This will be tracked in a new issue at #1022.

@tom114 tom114 closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Pipelines and workflows in IRIDA
Projects
None yet
Development

No branches or pull requests

3 participants