Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: items in refslots dont swap #171

Open
LeeWannacott opened this issue Feb 28, 2024 · 3 comments
Open

Bug: items in refslots dont swap #171

LeeWannacott opened this issue Feb 28, 2024 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@LeeWannacott
Copy link
Contributor

LeeWannacott commented Feb 28, 2024

You can override another refslot with the item from another refslot; which isn't the problem its that they don't swap.

Video:
https://github.com/peter-kish/gloot/assets/49783296/17515b3e-be52-4506-b8da-0d581407e636

I'm not sure what use case you would need a one to many relationship, but possibly there is (maybe in a hotbar)?

I don't really know what exactly what the behavior should be. However, I guess if you had ring slots you should be able to switch the items in the refSlots. 🤔

Note: I'm not using refSlot; so I'm not worried about this issue; was just experimenting and found it.

@LeeWannacott LeeWannacott changed the title Bug: Can override another refslot by dragging item from another refslot. Bug: items in refslot dont swap Feb 28, 2024
@LeeWannacott LeeWannacott changed the title Bug: items in refslot dont swap Bug: items in refslots dont swap Feb 28, 2024
@peter-kish
Copy link
Owner

peter-kish commented Feb 28, 2024

Yeah, this is intentional, though I'm also unsure if it was the right decision. It would definitely be useful to be able to swap items (not only in slots, but also in an InventoryGrid).
I guess I need to rethink this one...

@peter-kish peter-kish added the enhancement New feature or request label Feb 28, 2024
@peter-kish peter-kish added this to the 2.4.5 milestone Mar 1, 2024
@peter-kish peter-kish modified the milestones: 2.4.5, 2.4.6 Mar 24, 2024
@peter-kish
Copy link
Owner

Item swapping inside inventories and item slots is implemented in v2.4.6, but that still does not cover ItemRefSlots. Since their purpose became somewhat unclear after the introduction of ItemSlots, I'm currently leaning towards deprecating them. For that reason I don't think it makes a lot of sense to introduce new ItemRefSlot related logic...

I might replace them at some point with some sort of an "item drop area" control where the user can drop items and connect to some signals to define what happens to them. That would still allow for some custom slots without introducing complex classes with unclear purpose.

@LeeWannacott
Copy link
Contributor Author

LeeWannacott commented Apr 7, 2024

Since their purpose became somewhat unclear

Hmmm, Other than Deus Ex, I can't really think of any other game that does the ItemRef thing for inventory. (doesn't mean they don't exist though)

@peter-kish peter-kish added the wontfix This will not be worked on label Apr 8, 2024
@peter-kish peter-kish removed this from the 2.4.6 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants