Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix updating addlink_db_table with null values. #1035

Conversation

alireza-delavari
Copy link
Contributor

as in this comment mentioned: #1020 (comment)

after enabling "Proxy" checkbox in properties for any link item in table and clicking on OK button,
disabling "Proxy" checkbox wont save anymore.

its also same for other fields, for example setting "Referrer" field to empty wont save.

it was because of "updateAddLinkTable" method in "data_base.py" ,
when updating db table it was setting new null values to its previous stored value in db table.
so we couldn't update anything to null anymore.

@alireza-amirsamimi
Copy link
Member

Hello
As I said there, I don't have this problem :)
I can't confirm this bug.

@alireza-delavari
Copy link
Contributor Author

did you fill IP and Port field when enabling proxy checkbox?

I filmed my steps to make the bug more clear:
setting proxy check box enable, fill ip and port field, click ok,
then setting proxy check box disable click ok
, then open properties dialog again, proxy still is enable
persepolis_1_proxy.webm

its the same for other fields:
persepolis_2_referer.webm

@alireza-amirsamimi alireza-amirsamimi merged commit e7b8a00 into persepolisdm:master Oct 7, 2024
@alireza-amirsamimi
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants