Add internal queues for pubsub message transmission to clients. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaulk
force-pushed
the
shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to
branch
from
8015b9d
to
43f84cb
Compare
roekatz
reviewed
Aug 23, 2023
| await self._queues[subscription].put(data) | ||
|
|
||
| async def _handle_queue(self, subscription: Subscription): | ||
| while True: |
There was a problem hiding this comment.
I think you should catch CancelledError and quit the while
shaulk
force-pushed
the
shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to
branch
from
43f84cb
to
67c38cb
Compare
shaulk
force-pushed
the
shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to
branch
from
67c38cb
to
df8ae7e
Compare
asafc
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.