You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #2016 describes a problem where root cause is the way pcp-dstat.py has hard-coded mappings between instance filtering command line options and the specific plugins they apply to.
A cleaner solution would allow the plugin configuration files to specify this mapping. That way, as new config files are added (in PCP or by the user locally), the python code does not need to be changed to add the plugin names.
For example, the disk-util plugin from /etc/pcp/dstat/disk might gain a filter mapping specification something like:
These are the all of the relevant command line options that provide "filtertype" values:
-c, --cpu enable cpu stats
-C 0,3,total include cpu0, cpu3 and total
-d, --disk enable disk stats
-D total,sda include sda and total
--dm, --device-mapper enable device mapper stats
-L root,home,total include root, home and total
--md, --multi-device enable multi-device driver stats
-M total,md-0 include md-0 and total
--part, --partition enable disk partition stats
-P total,sdb2 include sdb2 and total
-i, --int enable interrupt stats
-I 9,CAL include int9 and function call interrupts
-n, --net enable network stats
-N eth1,total include eth1 and total
-s, --swap enable swap stats
-S swap1,total include swap1 and total
The text was updated successfully, but these errors were encountered:
Issue #2016 describes a problem where root cause is the way pcp-dstat.py has hard-coded mappings between instance filtering command line options and the specific plugins they apply to.
A cleaner solution would allow the plugin configuration files to specify this mapping. That way, as new config files are added (in PCP or by the user locally), the python code does not need to be changed to add the plugin names.
For example, the disk-util plugin from /etc/pcp/dstat/disk might gain a filter mapping specification something like:
These are the all of the relevant command line options that provide "filtertype" values:
The text was updated successfully, but these errors were encountered: