Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aug/popover #59

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Aug/popover #59

merged 2 commits into from
Mar 27, 2024

Conversation

yuntongf
Copy link

Add triggerType prop to ReviewPanelTrigger to allow two types of trigger: click and hover

When the trigger type is click:

  • to show review panel, click on course title
  • to close review panel, click on course title, or click on anywhere outside of the review panel

When the trigger type is hover:

  • to show review panel, hover on course title
  • to close review panel, click on anywhere outside of the review panel

Make course component trigger type to be click, but need to discuss UX

@yuntongf yuntongf merged commit 6e95a9a into master Mar 27, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant