Fix spawn tests in different environments #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcbaker are you available to review this? |
We are running our tests in different environments, sometimes with a terminal as stdin and sometimes with /dev/null as stdin. Both are seen as "not a pipe" by `test -p` so we use that to test if our python code redirects text into an external process.
|
It seems that |
I think we can assume that the intersection of alot and SunOS or similar is empty. Let's not make an issue of it and just use /dev/stderr and friends and reconsider should anyone ever run into issue with it? |
pazz
approved these changes
Aug 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running our tests in different environments, sometimes with a terminal as stdin and sometimes with /dev/null as stdin. Both are seen as "not a pipe" by
test -pso we use that to test if our python code redirects text into an external process.This fixes #1580.
This pull request is based on my comment #1580 (comment)