Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename _words to prefix, do not assign lowered to str #27

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

mahnunchik
Copy link
Contributor

When I ported it to CashAddr, I noticed some points that could be made clearer:

  1. Do not use _words variable name because the same name is used in the upper scope. data name matches with the error message.
  2. Do not assign lowered to function parameter str for readability and original str in error message.

@paulmillr
Copy link
Owner

@mahnunchik all good with regards to the port itself?

@paulmillr paulmillr merged commit c5cbf7b into paulmillr:main Dec 13, 2023
1 check passed
@mahnunchik
Copy link
Contributor Author

@paulmillr I'm working on it.

It was right idea to have separate module because I've to reuse btc-signer for legacy normal addresses.

@paulmillr
Copy link
Owner

If something doesn't work, please prepare a pr with all needed changes to make it work, so we can put it into one version: I don't want to release many scure-base releases in a row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants