Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PocketBase version 0.23.0-rc12 #103

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Support PocketBase version 0.23.0-rc12 #103

merged 10 commits into from
Nov 27, 2024

Conversation

skowrons
Copy link
Contributor

@skowrons skowrons commented Nov 14, 2024

Description

All changes based on Release Notes v0.23.0-rc1

  • feat: make updated, created field optional on base record
  • feat: merge old options fields with field type
  • feat: remove old schema field and use new fields field
  • feat: use new _superuser collection for url type generation
  • test: integration tests will use 0.23.0-rc12 currently
  • test: update all test cases and migrate the integration test db to newest schema version
  • doc: add supported version table in readme

Todo

  • remove updated and created fields from base record

Issue

closes #102
fixes #92

@skowrons
Copy link
Contributor Author

@patmood maybe the breaking changes of this version would be a good time to fix:

? I would be eager to help with this.

@skowrons skowrons changed the title Support PocketBase version 0.23.0-rc12 Draft: Support PocketBase version 0.23.0-rc12 Nov 14, 2024
PocketBase no longer adds those fields by default.
@skowrons skowrons changed the title Draft: Support PocketBase version 0.23.0-rc12 Support PocketBase version 0.23.0-rc12 Nov 15, 2024
Copy link
Owner

@patmood patmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for the thorough update.

I'm still getting up to speed on the PB changes but all looks good so far.

If you want to address the other issues you mentioned in separate PRs, that would be amazing.

README.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
src/constants.ts Show resolved Hide resolved
@patmood
Copy link
Owner

patmood commented Nov 19, 2024

Integrations tests are failing because OtpsRecord is missing sentTo field in the schema. This was added in rc13, so that's my fault for suggesting updating it. You can either change the Docker version back to rc12 or export a new schema from a newer PB version.

export type OtpsRecord = {
	collectionRef: string
	created?: IsoDateString
	id: string
	password: string
	recordRef: string
	**sentTo?: string**
	updated?: IsoDateString
}

Feel free to switch it back to rc12 as there will probably be more things like this before the final release.

@skowrons
Copy link
Contributor Author

I should have run the integration tests locally. Upgraded to rc14 and regenerate all needed files.

@skowrons
Copy link
Contributor Author

@patmood I have upgraded the integration tests to 0.23.1. This should now be ready for merge ^^

@mirus-ua
Copy link

Folks, thank you for your time and work

@patmood patmood merged commit 8744267 into patmood:main Nov 27, 2024
2 checks passed
@rzzo
Copy link

rzzo commented Nov 27, 2024

Thanks for the work on all of this everyone who worked on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pocketbase v0.23 support Types for View collections include created and updated
4 participants