Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customised pubKeyCredParams #579

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Allow customised pubKeyCredParams #579

merged 2 commits into from
Nov 18, 2024

Conversation

abergs
Copy link
Collaborator

@abergs abergs commented Nov 18, 2024

This fixes #533.

@abergs
Copy link
Collaborator Author

abergs commented Nov 18, 2024

@aseigler Let me know if you think this looks good.

This allows devs to customise what algo's they want to support when creating the options. By default it's the same list as before, minus RS1.

In conformance testing we added RS1 to the list.

I've run it through conformance and it passes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.01%. Comparing base (1c003bf) to head (6dddf89).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 12.50% 14 Missing ⚠️
Src/Fido2/Fido2.cs 0.00% 1 Missing ⚠️
Src/Fido2/RequestNewCredentialParams.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   76.03%   76.01%   -0.03%     
==========================================
  Files         101      101              
  Lines        2600     2627      +27     
  Branches      432      438       +6     
==========================================
+ Hits         1977     1997      +20     
- Misses        513      517       +4     
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@aseigler
Copy link
Collaborator

@aseigler Let me know if you think this looks good.

This allows devs to customise what algo's they want to support when creating the options. By default it's the same list as before, minus RS1.

In conformance testing we added RS1 to the list.

I've run it through conformance and it passes.

We had talked about this before, looks good to me!

@abergs abergs merged commit f8471ac into master Nov 18, 2024
11 checks passed
@abergs abergs deleted the customize-algs branch November 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dev to customize what algo's they support instead of hard coding in CredentialCreateOptions
3 participants