Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Quality #509

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Improve Code Quality #509

merged 12 commits into from
Jul 15, 2024

Conversation

iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Mar 5, 2024

A quick tidying utilizing .NET8.0 features.

  • Use HashSizeInBytes
  • Use .NET 8.0 throw helpers
  • Use FrozenDictionary to improve lookups
  • Use required properties
  • Use throw helpers
  • Improve nullability annotations

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 62.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 74.62%. Comparing base (9ad038b) to head (f742369).

Files Patch % Lines
...ls/Metadata/DisplayPNGCharacteristicsDescriptor.cs 0.00% 7 Missing ⚠️
Src/Fido2.Models/Metadata/EcdaaTrustAnchor.cs 0.00% 6 Missing ⚠️
Src/Fido2.Models/Metadata/BiometricStatusReport.cs 0.00% 2 Missing ⚠️
Src/Fido2.Models/AssertionOptions.cs 66.66% 1 Missing ⚠️
Src/Fido2.Models/Metadata/ExtensionDescriptor.cs 50.00% 1 Missing ⚠️
...Fido2.Models/Metadata/PatternAccuracyDescriptor.cs 0.00% 1 Missing ⚠️
...c/Fido2/Metadata/Fido2MetadataServiceRepository.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   74.49%   74.62%   +0.13%     
==========================================
  Files          98       98              
  Lines        2639     2633       -6     
  Branches      445      442       -3     
==========================================
- Hits         1966     1965       -1     
+ Misses        570      567       -3     
+ Partials      103      101       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon
Copy link
Contributor Author

@aseigler @abergs Ready for review / feedback.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks @iamcarbon for nice contributions and sorry for the long wait to get this in.

@abergs abergs merged commit b0bb79d into passwordless-lib:master Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants