Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change List<byte[]> storedDevicePublicKeys to IReadOnlyList<byte[]> #477

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

joegoldman2
Copy link
Contributor

Following #447, this PR changes List<byte[]> storedDevicePublicKeys to IReadOnlyList<byte[]>.

There is no impact on the demo website as the stored credential contains a List<byte[]> for the device's public keys, which is compatible with IReadOnlyList<byte[]>.

public List<byte[]> DevicePublicKeys { get; set; }

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5284757) 74.11% compared to head (b4c9e5a) 74.30%.

Files Patch % Lines
Src/Fido2/AuthenticatorAssertionResponse.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   74.11%   74.30%   +0.19%     
==========================================
  Files         100      100              
  Lines        2712     2705       -7     
  Branches      443      444       +1     
==========================================
  Hits         2010     2010              
+ Misses        598      591       -7     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon
Copy link
Contributor

Looks good to me!

@abergs abergs merged commit b8b36a0 into passwordless-lib:master Jan 3, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the rolist branch January 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants