Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review lifecycle of services registered in the DI container #459

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Review lifecycle of services registered in the DI container #459

merged 3 commits into from
Jan 26, 2024

Conversation

joegoldman2
Copy link
Contributor

Fixes #439.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (5284757) 74.11% compared to head (243b7de) 74.16%.

Files Patch % Lines
Src/Fido2.AspNet/Fido2NetLibBuilderExtensions.cs 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   74.11%   74.16%   +0.05%     
==========================================
  Files         100      100              
  Lines        2712     2710       -2     
  Branches      443      443              
==========================================
  Hits         2010     2010              
+ Misses        598      596       -2     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs
Copy link
Collaborator

abergs commented Nov 17, 2023

I would need to think about what side effect this change could have before this is merged.

I welcome others analysis on this...

@abergs
Copy link
Collaborator

abergs commented Jan 15, 2024

@iamcarbon Happy to hear if you have any thoughts

@iamcarbon
Copy link
Contributor

Looks good. 👍

@abergs
Copy link
Collaborator

abergs commented Jan 26, 2024

Thank you @joegoldman2 👍 Happy friday.

@abergs abergs merged commit 0a9886d into passwordless-lib:master Jan 26, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the fix/439 branch January 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review lifecycle of services registered in the DI container
4 participants