Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add unit tests which check pre-computed analytical expression #60

Open
dominikandreasseitz opened this issue May 17, 2023 · 13 comments
Labels
good first issue Good for newcomers testing

Comments

@dominikandreasseitz
Copy link
Collaborator

dominikandreasseitz commented May 17, 2023

Update for clarity: This issue is about the Module API.
Come up with simple circuits, compute the expected result analytically and check if the result matches.

  1. The first testfile should include (combinations of) pauli gates, rotation gates, controlled gates, the U-gate, etc.

Example

assert X(zero_state(n_qubits=1)) == one_state(n_qubits=1)
  1. The second testfile should be about convergence tests using a simple QuantumCircuit which you will fit on a simple sine.

To complete this issue at least one test per existing gate should be written.

@abrassel
Copy link

Hi, I'd like to work on this issue! Can you assign me as an owner?

@dominikandreasseitz
Copy link
Collaborator Author

Hey, welcome to Pyq and thanks for participating! yes, i can do that

@s-aldaihan
Copy link

I am also interested in this issue if still open for contributions @dominikandreasseitz

@dominikandreasseitz
Copy link
Collaborator Author

hi @s-aldaihan , of course we would be happy if you contributed more unit tests to PyQ. the issue/ potential reward is however already assigned to @abrassel. so i can either offer you (1) to contribute without a monetary reward (2) ask @abrassel if he is actually working on the issue/plans to submit an MR, if not, let me know

@s-aldaihan
Copy link

Thanks @dominikandreasseitz.
@abrassel Can you please let me know if you are still considering contributing to this issue?

@abrassel
Copy link

Hi! I am still planning on working on this. Typically I don't mind collaborating, but this particular issue seems pretty small. I'm not sure if there's a meaningful amount of collaboration to do

@s-aldaihan
Copy link

@abrassel Sure!
@dominikandreasseitz I would like to contribute without the monetary reward, if possible

@dominikandreasseitz
Copy link
Collaborator Author

great, so please coordinate with eachother then :) thanks @s-aldaihan ! and i dont think its a small issue ;) try thinking about edge cases! try to include every gate we have etc

@abrassel
Copy link

It's ok @s-aldaihan feel free to do. I'll go find another issue to work on :)

@dominikandreasseitz
Copy link
Collaborator Author

hey! hows it going here @abrassel @s-aldaihan

@abrassel
Copy link

abrassel commented Jun 7, 2023

Hi! As I mentioned earlier, I didn't want to compete on this project :)

@dominikandreasseitz
Copy link
Collaborator Author

oh ok sorry! my understanding was that you are collaborating, but i understand of course!

@dominikandreasseitz
Copy link
Collaborator Author

hi @s-aldaihan, are you working on this issue? if yes, i would assign you. otherwise i would ask someone else do it :) let me know please!

@RolandMacDoland RolandMacDoland changed the title Add unit tests which check pre-computed analytical expression [Testing] Add unit tests which check pre-computed analytical expression Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing
Projects
None yet
Development

No branches or pull requests

4 participants