Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvement delete dashboard modal #368

Merged
merged 4 commits into from
Nov 11, 2024
Merged

UX improvement delete dashboard modal #368

merged 4 commits into from
Nov 11, 2024

Conversation

pranavgoel29
Copy link
Contributor

@pranavgoel29 pranavgoel29 commented Nov 11, 2024 •
edited
Loading

Fixes #366

  • Moved the delete dashboard modal confirmation text from placeholder to modal content.
  • Corrected the class spelling for 'tilesViewContainer'.
  • Added some margin at the bottom of the tiles container in dashboard.

Deletion Modal

BEFORE:
image

AFTER:
image

@pranavgoel29 pranavgoel29 changed the title Ux improvement delete modal dashboard UX improvement delete dashboard modal Nov 11, 2024
@nitisht
Copy link
Member

nitisht commented Nov 11, 2024

Can we add the name in quotes to separate it out.

@pranavgoel29
Copy link
Contributor Author

Can we add the name in quotes to separate it out.

Done 😄

@praveen5959
Copy link
Contributor

Can you deploy this branch on Vercel for us to test it out once?

@nitisht nitisht merged commit 39c147b into parseablehq:main Nov 11, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX improvement in dashboard delete modal
3 participants
@pranavgoel29 @nitisht @praveen5959