Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-addon-api should be a dev dependency? #167

Open
lydell opened this issue Mar 19, 2024 · 1 comment
Open

node-addon-api should be a dev dependency? #167

lydell opened this issue Mar 19, 2024 · 1 comment

Comments

@lydell
Copy link

lydell commented Mar 19, 2024

Since all the binaries are prebuilt and binding.gyp isn’t part of the npm package, should node-addon-api be moved to be a dev dependency? binding.gyp is the only place that require('node-addon-api'), right? So it shouldn’t be needed other than as a dev dependency for builds?

@mischnic
Copy link
Member

Yes, that it true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants