Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/metadata: Update docs with recent changes #86

Open
kakkoyun opened this issue Feb 8, 2022 · 3 comments
Open

store/metadata: Update docs with recent changes #86

kakkoyun opened this issue Feb 8, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Feb 8, 2022

https://cloud-native.slack.com/archives/C01BB0M6K1U/p1644325866492779

@kakkoyun kakkoyun added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Feb 8, 2022
@metalmatze
Copy link
Member

Copied from Slack:

Hello, I’m messing about with Parca today on my 20% time, and I was just wondering… The docs say

for now, we’re using a SQLite in-memory by default
https://www.parca.dev/docs/storage

but it looks like you’re using Badger by default, which to my admittedly limited understanding is a KV store
https://github.com/parca-dev/parca/blob/v0.7.1/pkg/parca/parca.go#L73

@Dean-Coakley
Copy link

Looks like this can be closed as it was resolved in: #128 ?

@brancz
Copy link
Member

brancz commented Jun 24, 2022

We actually just changed this again which made the updated docs stale again. The organization of keys is thoroughly documented here though: https://github.com/parca-dev/parca/blob/main/pkg/metastore/kv.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants