Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer abstract method names mixup #270

Open
anderssonjohan opened this issue Nov 19, 2024 · 0 comments
Open

Serializer abstract method names mixup #270

anderssonjohan opened this issue Nov 19, 2024 · 0 comments

Comments

@anderssonjohan
Copy link

anderssonjohan commented Nov 19, 2024 •
edited
Loading

@Lxstr I got totally confused by this change 😅 First after using the code I realized the abstractmethods are mixed up. def dumps should be def loads and vice versa. (they are correct in the implementation on lines 129 and 137)

Originally posted by @anderssonjohan in 0c22ec6

Note: this concerns code still in the development branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anderssonjohan