[Bug] Fix for Octolock bypasses Ghost Invulnerability to lower Stats

[PrabbyDD]

What are the changes the user will see?

octolock properly interacts with ghost types

Why am I making these changes?

Fixes #4867

What are the changes from a developer perspective?

changed some tests around and removed some obsolete ones, as well as just removing canAdd from octolock tag

Screenshots/Videos

2024-11-19.18-54-16.mp4

2024-11-19.18-54-22.mp4

How to test the changes?

override files, as well as tests

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[innerthunder]

The move should fail when used against a Ghost-type instead of resolving and doing nothing.

I think the best approach to fix this would be to add a .condition() function to Octolock, Block, Mean Look, and Spider Web.

[PrabbyDD]

What is the intent of using the .condition()? Do I need to subtmit some function into it that checks whether the pokemon is a ghost type and then if it queue a message?

[innerthunder]

Renaming failIfGhostType -> failIfGhostTypeCondition for parity with the other condition functions

test added