[Tests] Enemy Held Item overrides are now applied after generateEnemyModifiers() #4922
+15
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
None.
Why am I making these changes?
This change is needed to test item-related moves and abilities without having unwanted items interfere with test conditions.
What are the changes from a developer perspective?
overrideModifiers and overrideHeldItems are now applied after generateEnemyModifiers() in encounter-phase.ts. Previously, they were applied in addEnemyPokemon(), but addEnemyPokemon() was run before generateEnemyModifiers() so the items in the override would be given but additional items could also be generated afterwards.
Checklist
beta
as my base branchnpm run test
)