Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask server has no dependency handling #201

Open
Venefilyn opened this issue Jan 14, 2023 · 1 comment
Open

Flask server has no dependency handling #201

Venefilyn opened this issue Jan 14, 2023 · 1 comment
Labels
kind/bug Something isn't working.

Comments

@Venefilyn
Copy link
Collaborator

Venefilyn commented Jan 14, 2023

While setting up the server for local development (without container) I noticed that there is nothing to indicate what you need to install when it comes to dependencies or what version you need. Ideally we should be using something similar to yarn or npm to handle dependencies and lock things down, even if it is minor

I propose that we should use Poetry to set this up

⬢ [fedora-toolbox:37] ❯ make run-dev-flask 
FLASK_ENV=development FLASK_APP=packit_dashboard.app flask-3 run --host=0.0.0.0
Usage: flask-3 run [OPTIONS]
Try 'flask-3 run --help' for help.

Error: While importing 'packit_dashboard.app', an ImportError was raised:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/flask/cli.py", line 218, in locate_app
    __import__(module_name)
  File "/var/home/spytec/projects/dashboard/packit_dashboard/app.py", line 3, in <module>
    from packit_dashboard.api.routes import api
  File "/var/home/spytec/projects/dashboard/packit_dashboard/api/routes.py", line 2, in <module>
    from packit_dashboard.utils import return_json
  File "/var/home/spytec/projects/dashboard/packit_dashboard/utils.py", line 1, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
@Venefilyn
Copy link
Collaborator Author

Venefilyn commented Jan 14, 2023

Note, this is on a fresh-ish toolbox container

@FrNecas FrNecas moved this from new to backlog in Packit Kanban Board Jan 16, 2023
@TomasTomecek TomasTomecek added the kind/bug Something isn't working. label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working.
Projects
Status: backlog
Development

No branches or pull requests

2 participants