Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Implement proper code page selection for OEM archives #63

Closed
unxed opened this issue Jul 16, 2020 · 11 comments
Closed

[patch] Implement proper code page selection for OEM archives #63

unxed opened this issue Jul 16, 2020 · 11 comments

Comments

@unxed
Copy link
Contributor

unxed commented Jul 16, 2020

https://sourceforge.net/p/p7zip/bugs/187/#816e

Original discussion: mate-desktop/engrampa#5

@jinfeihan57
Copy link
Contributor

Can you provide a PR?

@unxed
Copy link
Contributor Author

unxed commented Jul 17, 2020

Can you provide a PR?

#64

@jinfeihan57
Copy link
Contributor

It's been merged,thanks.

@unxed unxed closed this as completed Jul 20, 2020
@jinfeihan57 jinfeihan57 reopened this Jul 21, 2020
@jinfeihan57
Copy link
Contributor

Compilation error on cygwin.

@unxed
Copy link
Contributor Author

unxed commented Jul 21, 2020

@jinfeihan57 got no windows. Сan you please provide an error log?

@jinfeihan57
Copy link
Contributor

jinfeihan57 commented Jul 22, 2020

截图
Can't find libiconv_open.
[I added the compilation conditions. ]
(jinfeihan57@0e0a1a8?diff=unified)

@unxed
Copy link
Contributor Author

unxed commented Jul 22, 2020

So it looks like compiler found some iconv.h header somewhere, but linker can not find relevant object file.

Maybe libiconv is absent in cygwin installation and iconv.h from glibc is used instead?
If so, installing this package may help:
http://www.cygwin.com/packages/summary/libiconv-devel.html

Related discussion:
https://stackoverflow.com/questions/4709178/how-do-i-link-glibcs-implementation-of-iconv/4709207#4709207

@jinfeihan57
Copy link
Contributor

Actually I do insatll libiconv-debuginfo.
I don't know why libiconv-debuginfo not work. But I will try libiconv-devel later.

@jinfeihan57
Copy link
Contributor

截图
I installed libiconv-devel on cygwin, But it still won't work. same ERROR.

@unxed
Copy link
Contributor Author

unxed commented Oct 11, 2020

Can't digg within this as I have no windows installed. Maybe we can add conditional compilation rules to skip this part under cygwin for now?

@jinfeihan57
Copy link
Contributor

I already fixed it. check #68 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants