Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the PNG format for HEIC thumbnails #41284

Open
tmysik opened this issue Jul 5, 2024 · 1 comment
Open

Stop using the PNG format for HEIC thumbnails #41284

tmysik opened this issue Jul 5, 2024 · 1 comment

Comments

@tmysik
Copy link

tmysik commented Jul 5, 2024

Steps to reproduce

  1. enable preview for HEIC files (use the latest Imagick, install php-imagick and enable preview in the config, enabled by default)
  2. upload a HEIC file (photo)
  3. access this file via your web browser
  4. its preview(s) is (are) generated, in the PNG (!) format

Expected behaviour

The preview image(s) should not be created in the PNG format, since this format is not usable for photos at all. In my case, the preview files occupy even more space than the original, large photos themselves (20 GB vs. 19 GB). It seems to me that the e.g. the JPG format would be much more suitable.

Actual behaviour

Thumbnails of any HEIC file/photo are generated in the PNG format.

Note: The reason is that the HEIC.php file that generates these thumbnails extends the Bitmap class which uses only the PNG format and cannot be configured to any other file type easily.

Thank you.

@iasdeoupxe
Copy link
Contributor

Could be wrong but looks like all image types (not only HEIC) are getting thumbnails in the .png format, at least noticed .jpg files on my installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants