Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Open and create .url shortcut files #4413

Closed
12 tasks done
TheOneRing opened this issue May 28, 2024 · 2 comments · Fixed by #4420
Closed
12 tasks done

[FEATURE REQUEST] Open and create .url shortcut files #4413

TheOneRing opened this issue May 28, 2024 · 2 comments · Fixed by #4420

Comments

@TheOneRing
Copy link

TheOneRing commented May 28, 2024

Please implement support for creating and opening .url files.
The feature should behave similarly to owncloud/ios-app#1344 but follow the normal android UX.

TASKS

  • Research (if needed)
  • Create branch feature/open_create_url_shortcut_files
  • Development tasks
    • Create dialog fragment with url and name file inputs
    • Upload the file to the server
    • Click on file url and download
    • Open alert dialog to navigate to browser
    • Redirect to the browser
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/open_create_url_shortcut_files into master
@jesmrec
Copy link
Collaborator

jesmrec commented May 29, 2024

Some Android specific details:

  • Shortcuts should be a new option in the FAB menu

  • We need an icon, similar to the iOS one, for the .url files

  • As first iteration, only two input fields: name (taking care of name conflicts) and url (with no validation, but error handling). Later, we can take advantage of deeplinks as iOS does (open to discussion)

quick info about .url files

https://fileinfo.com/extension/url
https://www.lyberty.com/encyc/articles/tech/dot_url_format_-_an_unofficial_guide.html

@Aitorbp Aitorbp self-assigned this May 30, 2024
@Aitorbp Aitorbp added this to the 4.3 - Current milestone Jun 7, 2024
@Aitorbp
Copy link
Contributor

Aitorbp commented Jun 7, 2024

Hello @tbsbdr!
With reference to this issue, I have doubts about the choice of the icon. To align them with iOS and web, I have chosen the same icon. Is this correct? Image below:

Captura de pantalla 2024-06-07 a las 13 57 53

On the other hand, I have put the shortcut icon as the last item in the list in the FAB. Is this order correct?

  1. Upload
  2. New folder
  3. New shortcut

Captura de pantalla 2024-06-07 a las 13 58 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants