Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(pci-common): add vite config to publish library #14285

Open
wants to merge 12 commits into
base: release/public-cloud-w49
Choose a base branch
from
Open

build(pci-common): add vite config to publish library #14285

wants to merge 12 commits into from
+794 −682

Conversation

fredericvilcot
Copy link
Contributor

@fredericvilcot fredericvilcot commented Nov 26, 2024 •
edited by anooparveti
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2321
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This PR adds configuration to enable the publishing of the library.

Nota:

  • The build phase only targets esm file, because of the uselessness of building cjs or umd files that are not compatible anymore with certain libraries like @tanstak/react-query.
    Furthermore, all browsers are now compatible with ES modules so there is no need to weigh down the produced dist folder.
    As a consequence, there is no need to add output.globals instructions for rollup because this is only needed for umd files.

  • I added hidden sourcemap files to ensure a better debugging with tools like Sentry without exposing any reference to the source code in the browser.

Related

Will be treated with #14344

@github-actions github-actions bot added the build Changes that affect the build system or external dependencie label Nov 26, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 26, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 26, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 26, 2024
@fredericvilcot fredericvilcot marked this pull request as ready for review November 26, 2024 16:37
@fredericvilcot fredericvilcot requested a review from a team as a code owner November 26, 2024 16:37
ppprevost
ppprevost previously approved these changes Nov 26, 2024
View reviewed changes
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Nov 26, 2024
lionel95200x
lionel95200x previously approved these changes Nov 26, 2024
View reviewed changes
@github-actions github-actions bot removed the build Changes that affect the build system or external dependencie label Nov 26, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 28, 2024
selm3n and others added 11 commits November 29, 2024 11:34
@selm3n @anooparveti
fix(pci-object-storage): spinner when adding a localzone (#14268)
42a5738 
ref: TAPC-2294

Signed-off-by: Selmen AKRMI <[email protected]>
@y4nnL @anooparveti
fix(pci.instances): use shell to navigate to public-ip (#13948)
4b8373d 
ref: TAPC-876

Signed-off-by: Yann Lojewski <[email protected]>
@ppprevost @ovh-ux-cds @anooparveti
feat(pci-rancher); add pci rancher id (#14236)
80f5955 
ref: TAPC-1024

Signed-off-by: Pierre-Philippe <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@seven-amid @anooparveti
fix(pci-private-registry): fix design issues (#13951)
056bd06 
ref: DTCORE-2805

Signed-off-by: LIDRISSI Hamid <[email protected]>
@frenautvh @anooparveti
fix(pci-block-storage): design css fixes (#13884)
8374b2c 
ref: DTCORE-2802

Signed-off-by: Florian Renaut <[email protected]>
@ppprevost @ovh-ux-cds @anooparveti
feat(pci-rancher):display Orchestrated vCPU managed error (#14257)
f0a42b9 
ref: TAPC-2109

Signed-off-by: Pierre-Philippe <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@selm3n @ovh-cds @anooparveti
feat(pci-object-storage): do not show warning when deleting empty buc…
dd72ae3 
…ket (#14256)

ref: TAPC-2041

Signed-off-by: Selmen AKRMI <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@selm3n @ovh-cds @anooparveti
fix(pci-object-storage): fix wording (#14298)
a0aea59 
ref: TAPC-1929

Signed-off-by: Selmen AKRMI <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@lionel95200x @anooparveti
feat(pci-savings-plan): change tile background color and price promot…
61c3406 
…ion (#14262)

ref: TAPC-2305

Signed-off-by: Lionel Bueno <[email protected]>
@frenautvh @anooparveti
fix(pci-users): design css fixes (#13892)
b2e8957 
ref: DTCORE-2807

Signed-off-by: Florian Renaut <[email protected]>
@kqesar @anooparveti
fix(pci-gateway): design css fixes (#14038)
7bfdd62 
ref: DTCORE-2809

Signed-off-by: Yoann Fievez <[email protected]>
@anooparveti anooparveti requested review from a team as code owners November 29, 2024 06:31
@anooparveti anooparveti requested review from sidlynx and kqesar and removed request for a team November 29, 2024 06:31
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 29, 2024
@kqesar @anooparveti
fix(pci-vouchers): design css fixes (#13891)
f7946ee 
ref: DTCORE-2808

Signed-off-by: Yoann Fievez <[email protected]>
@anooparveti
Copy link
Contributor

Rebasing with release branch.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file universe-public-cloud build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie has conflicts Has conflicts to resolve before merging labels Nov 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@frenautvh frenautvh frenautvh approved these changes

@anooparveti anooparveti anooparveti approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ppprevost ppprevost Awaiting requested review from ppprevost

@lionel95200x lionel95200x Awaiting requested review from lionel95200x

@SimonChaumet SimonChaumet Awaiting requested review from SimonChaumet

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
build Changes that affect the build system or external dependencie dependencies Pull requests that update a dependency file has conflicts Has conflicts to resolve before merging quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.